docs(prover): explain why header.state_root replaces morph_diskRoot#956
Conversation
The host executor switched from the custom `morph_diskRoot` RPC field to the standard `block.header.state_root` in commit e0756a4, but the rationale was not captured in the code. After the zkTrie -> MPT migration (PR #886) the header state_root is the authoritative MPT root, so the custom field became redundant. Add a comment so future readers don't have to dig through git history to understand the equivalence.
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Summary
morph_diskRootRPC field to the standardblock.header.state_rootin commit e0756a4, but the rationale was not captured in the code.post_state_rootandprev_state_rootso future readers don't need to dig through git history to understand the equivalence.Test plan
cargo check -p prover-executor-host