Skip to content

docs(prover): explain why header.state_root replaces morph_diskRoot#956

Merged
chengwenxi merged 1 commit into
feat/multi_batchfrom
docs/prover-state-root-comment
May 18, 2026
Merged

docs(prover): explain why header.state_root replaces morph_diskRoot#956
chengwenxi merged 1 commit into
feat/multi_batchfrom
docs/prover-state-root-comment

Conversation

@chengwenxi
Copy link
Copy Markdown
Collaborator

Summary

  • The host executor was migrated from the custom morph_diskRoot RPC field to the standard block.header.state_root in commit e0756a4, but the rationale was not captured in the code.
  • After the zkTrie → MPT migration (PR Feat: Upgrade Prover to SP1 v5, Integrate Morph-Reth as STF, and Replace zkTrie with MPT #886) the header state_root is the authoritative MPT root, so the custom field became redundant.
  • Add a short comment at both post_state_root and prev_state_root so future readers don't need to dig through git history to understand the equivalence.
  • Addresses audit finding INFO-1 from the 2026-05-15 multi-blob audit (PR feat: multi blob #935).

Test plan

  • cargo check -p prover-executor-host
  • Comment-only change; no behavior modified.

The host executor switched from the custom `morph_diskRoot` RPC field to
the standard `block.header.state_root` in commit e0756a4, but the
rationale was not captured in the code. After the zkTrie -> MPT
migration (PR #886) the header state_root is the authoritative MPT
root, so the custom field became redundant. Add a comment so future
readers don't have to dig through git history to understand the
equivalence.
@chengwenxi chengwenxi requested a review from a team as a code owner May 18, 2026 08:17
@chengwenxi chengwenxi requested review from panos-xyz and removed request for a team May 18, 2026 08:17
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 18, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c786aad7-aab7-447e-9f98-36e835c9197f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/prover-state-root-comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@chengwenxi chengwenxi merged commit af9e631 into feat/multi_batch May 18, 2026
3 checks passed
@chengwenxi chengwenxi deleted the docs/prover-state-root-comment branch May 18, 2026 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant