fix(prover): replace .unwrap() with map_err in blob KZG verification#955
Conversation
The three .unwrap() calls on KzgRsBlob/Bytes48 slice conversions could panic the prover process if the upstream RPC returned malformed blob data, dropping all queued proofs. Convert to map_err(...)? so the current request fails while the process keeps serving other tasks.
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Summary
.unwrap()calls inBlobVerifier::verify_kzg(onKzgRsBlob::from_slice/Bytes48::from_slice) could panic the prover process if the upstream RPC returned malformed blob data, dropping every queued proof along with it..map_err(|e| anyhow!(...))?so the current request fails cleanly while the process keeps serving other proofs.Test plan
cargo check -p prover-executor-client