Skip to content

fix(prover): replace .unwrap() with map_err in blob KZG verification#955

Merged
chengwenxi merged 1 commit into
feat/multi_batchfrom
fix/prover-blob-verifier-unwrap
May 18, 2026
Merged

fix(prover): replace .unwrap() with map_err in blob KZG verification#955
chengwenxi merged 1 commit into
feat/multi_batchfrom
fix/prover-blob-verifier-unwrap

Conversation

@chengwenxi
Copy link
Copy Markdown
Collaborator

@chengwenxi chengwenxi commented May 18, 2026

Summary

  • The three .unwrap() calls in BlobVerifier::verify_kzg (on KzgRsBlob::from_slice / Bytes48::from_slice) could panic the prover process if the upstream RPC returned malformed blob data, dropping every queued proof along with it.
  • Convert each to .map_err(|e| anyhow!(...))? so the current request fails cleanly while the process keeps serving other proofs.
  • Addresses audit finding INFO-3 from the 2026-05-15 multi-blob audit (PR feat: multi blob #935).

Test plan

  • cargo check -p prover-executor-client
  • Existing prover unit/integration tests pass in CI

The three .unwrap() calls on KzgRsBlob/Bytes48 slice conversions could
panic the prover process if the upstream RPC returned malformed blob
data, dropping all queued proofs. Convert to map_err(...)? so the
current request fails while the process keeps serving other tasks.
@chengwenxi chengwenxi requested a review from a team as a code owner May 18, 2026 08:11
@chengwenxi chengwenxi requested review from r3aker86 and removed request for a team May 18, 2026 08:11
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 18, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7cc8abb9-caf7-4313-a6d7-318432005f01

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/prover-blob-verifier-unwrap

Comment @coderabbitai help to get the list of available commands and usage tips.

@chengwenxi chengwenxi merged commit daf6937 into feat/multi_batch May 18, 2026
3 checks passed
@chengwenxi chengwenxi deleted the fix/prover-blob-verifier-unwrap branch May 18, 2026 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant