Skip to content

feat(publisher): copy version from package.json and prefer mcpName in init #1145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JosephDoUrden wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(publisher): copy version from package.json and prefer mcpName in init #1145

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 29 additions & 3 deletions cmd/publisher/commands/init.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,10 @@ func InitCommand() error {
// Try to detect values from environment
name := detectServerName(subfolder)
description := detectDescription()
version := "1.0.0"
version := getVersionFromPackageJSON()
if version == "" {
version = "1.0.0"
}
repoURL := detectRepoURL()
repoSource := MethodGitHub
if repoURL != "" && !strings.Contains(repoURL, "github.com") {
Expand Down Expand Up @@ -140,9 +143,13 @@ func getNameFromPackageJSON() string {
return ""
}

name, ok := pkg["name"].(string)
// Prefer mcpName over name, as the server name must match mcpName
name, ok := pkg["mcpName"].(string)
if !ok || name == "" {
return ""
name, ok = pkg["name"].(string)
if !ok || name == "" {
return ""
}
}

// Convert npm package name to MCP server name
Expand All @@ -156,6 +163,25 @@ func getNameFromPackageJSON() string {
return fmt.Sprintf("io.github.<your-username>/%s", name)
}

func getVersionFromPackageJSON() string {
data, err := os.ReadFile("package.json")
if err != nil {
return ""
}

var pkg map[string]any
if err := json.Unmarshal(data, &pkg); err != nil {
return ""
}

version, ok := pkg["version"].(string)
if !ok || version == "" {
return ""
}

return version
}

func detectServerName(subfolder string) string {
// Try to get from git remote
repoURL := detectRepoURL()
Expand Down
Loading