Fix docstring and type hints for l_freq and h_freq in ICA.score_sources (#13689)#13784
Fix docstring and type hints for l_freq and h_freq in ICA.score_sources (#13689)#13784DivyanshiJadon wants to merge 1 commit intomne-tools:mainfrom
Conversation
bb83482 to
e064330
Compare
|
@DivyanshiJadon thanks for the PR, but there is already PR for this issue and i think @1himan is working on that, so i'll suggest to ask before making duplicate efforts, it will save your time, also please feel free to look other issues which interests you. |
|
Thanks for the heads up! I’ll check before picking issues next time and
look into other ones .
…On Fri, 27 Mar, 2026, 3:57 pm Aniket, ***@***.***> wrote:
*Aniketsy* left a comment (mne-tools/mne-python#13784)
<#13784?email_source=notifications&email_token=BF5JELA3RNEBHX6PPH6URMT4SZJRVA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMJUGE3DGNJSGI4KM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJNLQOJPWG33NNVSW45C7N5YGK3S7MNWGSY3L#issuecomment-4141635228>
@DivyanshiJadon <https://github.com/DivyanshiJadon> thanks for the PR,
but there is already PR for this issue and i think @1himan
<https://github.com/1himan> is working on that, so i'll suggest to ask
before making duplicate efforts, it will save your time, also please feel
free to look other issues which interests you.
thanks again :)
—
Reply to this email directly, view it on GitHub
<#13784?email_source=notifications&email_token=BF5JELA3RNEBHX6PPH6URMT4SZJRVA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMJUGE3DGNJSGI4KM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJNLQOJPWG33NNVSW45C7N5YGK3S7MNWGSY3L#issuecomment-4141635228>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BF5JELD4Z7BRVWC3CJHCIOL4SZJRVAVCNFSM6AAAAACW6OG4VGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DCNBRGYZTKMRSHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
so we closing this @DivyanshiJadon ... or what? Because maintainers are already having a hard time reviewing PRs(the numbers have surged in the past ~3months), so we don't want to add on top of that. But anyways if you're willing to make an effort on this please read the discussion I gave link to in the comment above. my hunch is this: The main problem was adding |
|
Since these changes are relevant to the topic, feel free to merge them if
you want. You can continue working on the remaining changes and merge them
later.
…On Fri, 27 Mar, 2026, 4:41 pm Himanshu Mahor, ***@***.***> wrote:
*1himan* left a comment (mne-tools/mne-python#13784)
<#13784?email_source=notifications&email_token=BF5JELHOBVOAXR22EUBV77T4SZOXDA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMJUGE4DKOBWGI32M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJNLQOJPWG33NNVSW45C7N5YGK3S7MNWGSY3L#issuecomment-4141858627>
so we closing this @DivyanshiJadon <https://github.com/DivyanshiJadon>
... or what?
—
Reply to this email directly, view it on GitHub
<#13784?email_source=notifications&email_token=BF5JELHOBVOAXR22EUBV77T4SZOXDA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMJUGE4DKOBWGI32M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJNLQOJPWG33NNVSW45C7N5YGK3S7MNWGSY3L#issuecomment-4141858627>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BF5JELBCMGM2UL46DNDDZDT4SZOXDAVCNFSM6AAAAACW6OG4VGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DCNBRHA2TQNRSG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Adding type hints to just a couple of function args is not something we will merge. Our goal is to hint entire files / submodules at a time. Additionally, the pattern description changes (e.g. from "low pass" to "low cutoff") are incorrect --- the low cutoff is associated with the high pass filter |
|
Okay
…On Sat, 28 Mar, 2026, 4:51 pm Daniel McCloy, ***@***.***> wrote:
*drammock* left a comment (mne-tools/mne-python#13784)
<#13784?email_source=notifications&email_token=BF5JELE6JP7JTRUHAINQ6FD4S6YTFA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMJUG44DQNBXHE4KM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJNLQOJPWG33NNVSW45C7N5YGK3S7MNWGSY3L#issuecomment-4147884798>
Adding type hints to just a couple of function args is not something we
will merge. Our goal is to hint entire files / submodules at a time.
Additionally, the pattern description changes (e.g. from "low pass" to "low
cutoff") are incorrect --- the low cutoff is associated with the high pass
filter
—
Reply to this email directly, view it on GitHub
<#13784?email_source=notifications&email_token=BF5JELE6JP7JTRUHAINQ6FD4S6YTFA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMJUG44DQNBXHE4KM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJNLQOJPWG33NNVSW45C7N5YGK3S7MNWGSY3L#issuecomment-4147884798>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BF5JELFUNXDCQJ52UTF25AT4S6YTFAVCNFSM6AAAAACW6OG4VGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DCNBXHA4DINZZHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
(Fixes #13689)
What does this implement/fix?
This PR makes two small, targeted changes in
score_sources: