deprecate assignment to some fields#1372
Open
sebffischer wants to merge 3 commits intomainfrom
Open
Conversation
sebffischer
commented
Aug 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We make some fields that will in the future be read-only active bindings.
Before we can actually make them read-only, we need to update all packages to not assign to them in the tests.
@be-marc The backwards compatability test now fails because we can't
$instantiate()an old resampling again because the field$task_hashis now private$.task_hash. I think this test is a bit strict though, do we really need this?