Add 'Mark as Done' button for session archiving#304473
Draft
mrleemurray wants to merge 3 commits intomainfrom
Draft
Add 'Mark as Done' button for session archiving#304473mrleemurray wants to merge 3 commits intomainfrom
mrleemurray wants to merge 3 commits intomainfrom
Conversation
Co-authored-by: Copilot <copilot@github.com>
…sion state checks Co-authored-by: Copilot <copilot@github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a “Mark as Done” control to the Agent Sessions window title bar to archive the current session (and rely on existing session-archiving behavior to advance to a new session view), including styling and render-state tracking.
Changes:
- Track active session “established/archived” state in the title bar render key to conditionally render the new control.
- Add a “Mark as Done” button in the sessions title bar that archives the active session.
- Add CSS styles for the new title bar button (hover + focus-visible).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/vs/sessions/contrib/sessions/browser/sessionsTitleBarWidget.ts | Adds session-state tracking and renders a new “Mark as Done” button that archives the active session. |
| src/vs/sessions/contrib/sessions/browser/media/sessionsTitleBarWidget.css | Adds styling for the new title bar “Mark as Done” button. |
src/vs/sessions/contrib/sessions/browser/sessionsTitleBarWidget.ts
Outdated
Show resolved
Hide resolved
src/vs/sessions/contrib/sessions/browser/sessionsTitleBarWidget.ts
Outdated
Show resolved
Hide resolved
src/vs/sessions/contrib/sessions/browser/sessionsTitleBarWidget.ts
Outdated
Show resolved
Hide resolved
src/vs/sessions/contrib/sessions/browser/sessionsTitleBarWidget.ts
Outdated
Show resolved
Hide resolved
…ark Session As Done action Co-authored-by: Copilot <copilot@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A "Mark as Done" button has been added to the sessions title bar, allowing users to archive sessions. The button includes focus styles and checks the session state before archiving. Test the functionality by interacting with the button in the sessions title bar.