Fix copy-paste bug in performance view blocking startup count#304452
Open
ShehabSherif0 wants to merge 1 commit intomicrosoft:mainfrom
Open
Fix copy-paste bug in performance view blocking startup count#304452ShehabSherif0 wants to merge 1 commit intomicrosoft:mainfrom
ShehabSherif0 wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an incorrect “blocking startup” count in the Startup Performance (perf view) summary table by counting workbench contributions from both lifecycle phases that block startup.
Changes:
- Correct the blocking startup contributions count to add
LifecyclePhase.Starting+LifecyclePhase.Ready(instead of double-countingStarting).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #304451
The "blocking startup" count in the performance view uses
LifecyclePhase.Startingfor both operands of the addition, double-countingStartingcontributions and omittingReadycontributions entirely.The correct pattern is visible in the same file's
_addWorkbenchContributionsPerfMarksTable(), which correctly lists bothStartingandReadyphases.Before:
(contribTimings.get(LifecyclePhase.Starting)?.length ?? 0) + (contribTimings.get(LifecyclePhase.Starting)?.length ?? 0)After:
(contribTimings.get(LifecyclePhase.Starting)?.length ?? 0) + (contribTimings.get(LifecyclePhase.Ready)?.length ?? 0)