Sessions - refactor and fix bug with file tracking#4665
Open
Sessions - refactor and fix bug with file tracking#4665
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors repository-change tracking for Copilot CLI Sessions to avoid stale/incorrect trackers and simplify lifecycle management, addressing a bug in file/change tracking while sessions are active.
Changes:
- Remove per-session
Disposabletracking of repository trackers inCopilotCLIChatSessionParticipant, and instead rely on the sharedChatSessionRepositoryTrackerto manage tracker lifecycle. - Update
ChatSessionRepositoryTracker.trackRepositoryChangesto bePromise<void>and replace stale trackers when the underlyingRepositoryStateinstance changes. - Adjust the unit test mock to match the new
trackRepositoryChangesreturn type.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/extension/chatSessions/vscode-node/test/copilotCLIChatSessionParticipant.spec.ts | Updates the repository tracker mock to return void instead of Disposable.None. |
| src/extension/chatSessions/vscode-node/copilotCLIChatSessionsContribution.ts | Removes per-session tracker disposal bookkeeping and calls repository tracking without storing a disposable. |
| src/extension/chatSessions/vscode-node/chatSessionRepositoryTracker.ts | Refactors repository tracking to be internally managed, and adds logic to detect/replace stale trackers based on RepositoryState identity. |
zhichli
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.