nes: trigger on active editor change only after NES acceptance

[ulugbekna]

No description provided.

[Copilot]

Pull request overview

Updates Next Edit Suggestions (NES) inline-edits triggering behavior by changing default configuration so editor/document-switch triggers are enabled by default and gated behind “after acceptance” strategy.

Changes:

• Set chat.inlineEdits.triggerOnEditorChangeAfterSeconds default to 10 (previously unset/disabled by default).
• Set internal chat.advanced.inlineEdits.triggerOnEditorChangeStrategy default to AfterAcceptance.
• Add "default": 10 to the corresponding package.json setting contribution.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
src/platform/configuration/common/configurationService.ts	Changes defaults for editor-change trigger timing and default gating strategy.
package.json	Updates the public configuration schema default for triggerOnEditorChangeAfterSeconds.

[Copilot]

Changing the default for chat.inlineEdits.triggerOnEditorChangeAfterSeconds from undefined to 10 enables editor-change/document-switch triggering by default. This setting is also treated as a boolean in InlineEditTriggerer._isSameLineCooldownActive (any truthy number bypasses the same-line cooldown), so this default effectively disables the same-line cooldown for all users. If the intent is only to enable document-switch triggering, consider decoupling the cooldown-bypass behavior from this setting (or keep the default undefined and gate via experimentation).

Suggested change

	export const InlineEditsTriggerOnEditorChangeAfterSeconds = defineAndMigrateExpSetting<number | undefined>('chat.advanced.inlineEdits.triggerOnEditorChangeAfterSeconds', 'chat.inlineEdits.triggerOnEditorChangeAfterSeconds', 10);
	export const InlineEditsTriggerOnEditorChangeAfterSeconds = defineAndMigrateExpSetting<number | undefined>('chat.advanced.inlineEdits.triggerOnEditorChangeAfterSeconds', 'chat.inlineEdits.triggerOnEditorChangeAfterSeconds', undefined);

[Copilot]

The schema allows null to disable this setting, but now that the default is 10 it will be enabled for everyone unless they explicitly set null. Please confirm this is intended (it’s a noticeable behavior change), and consider adding a lower bound (e.g., minimum 0) so negative values can’t produce surprising behavior in time-threshold calculations.

Suggested change

	"default": 10,
	"default": 10,
	"minimum": 0,