Adding an LSP query tool for Copilot CLI (no need for standalone LSP server setup in lsp.json)#4409
Open
lukka wants to merge 5 commits intomicrosoft:mainfrom
Open
Adding an LSP query tool for Copilot CLI (no need for standalone LSP server setup in lsp.json)#4409lukka wants to merge 5 commits intomicrosoft:mainfrom
lukka wants to merge 5 commits intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new MCP tool to the Copilot CLI VS Code-backed session that enables invoking selected VS Code “execute*Provider” / LSP-style commands and returning their results to the CLI.
Changes:
- Added
run_lsp_queryMCP tool to execute a curated set of VS Code LSP-related commands and format results for CLI consumption. - Wired the new tool into the Copilot CLI MCP tool registration pipeline.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/extension/chatSessions/copilotcli/vscode-node/tools/runLspQuery.ts |
Implements the new run_lsp_query tool: argument schema, command execution, result grouping, and large-output handling. |
src/extension/chatSessions/copilotcli/vscode-node/tools/index.ts |
Registers run_lsp_query alongside existing Copilot CLI MCP tools. |
Comments suppressed due to low confidence (1)
src/extension/chatSessions/copilotcli/vscode-node/tools/runLspQuery.ts:22
- The allowlist includes commands that strongly imply additional required arguments beyond the
(uri),(uri, position), or(query)calling conventions implemented below (e.g. theexecuteFormat*commands typically need range/options). As implemented, those commands will be invoked without required parameters and are likely to fail. Either narrow thecommandenum to only commands supported by the current argument model, or extend the schema/dispatch to accept and pass the required parameters per command.
'vscode.executeFormatDocumentProvider',
'vscode.executeFormatRangeProvider',
'vscode.executeFormatOnTypeProvider',
src/extension/chatSessions/copilotcli/vscode-node/tools/runLspQuery.ts
Outdated
Show resolved
Hide resolved
src/extension/chatSessions/copilotcli/vscode-node/tools/runLspQuery.ts
Outdated
Show resolved
Hide resolved
src/extension/chatSessions/copilotcli/vscode-node/tools/runLspQuery.ts
Outdated
Show resolved
Hide resolved
lukka
force-pushed
the
dev/lukka/lsp-for-ccli
branch
from
ace1f0c to
6807a5c
Compare
lukka
changed the title
lukka
force-pushed
the
dev/lukka/lsp-for-ccli
branch
from
6807a5c to
63a2e05
Compare
lukka
force-pushed
the
dev/lukka/lsp-for-ccli
branch
from
63a2e05 to
e66a8c3
Compare
lukka
force-pushed
the
dev/lukka/lsp-for-ccli
branch
from
e66a8c3 to
956cbbe
Compare
…licit about what each command is doing/providing, for better LLM understanding via Semantic Operations. - fix up tests.
lukka
force-pushed
the
dev/lukka/lsp-for-ccli
branch
from
956cbbe to
a818e9e
Compare
DonJayamanne
approved these changes
Mar 16, 2026
Collaborator
|
@lukka please can you address the Copilot review comments |
DonJayamanne
requested changes
Mar 16, 2026
Collaborator
DonJayamanne
left a comment
DonJayamanne
left a comment
There was a problem hiding this comment.
@lukka please can you address the Copilot review comments
Member
Author
@DonJayamanne I addressed all the Copilot's suggestions as well, let me know. |
Member
Author
|
@DonJayamanne i solved all comment, let me know how I can help to move this forward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a tool that exposes LSP VSCode capabilities for Copilot CLI