[http-client-java] mgmt premium, fix sample entry point and serviceClient reference for autorest#10082
Open
XiaofeiCao wants to merge 5 commits intomainfrom
Open
[http-client-java] mgmt premium, fix sample entry point and serviceClient reference for autorest#10082XiaofeiCao wants to merge 5 commits intomainfrom
XiaofeiCao wants to merge 5 commits intomainfrom
Conversation
microsoft-github-policy-service
Bot
added
the
emitter:client:java
Contributor
|
All changed packages have been documented.
Show changes
|
Collaborator
|
You can try these changes here
|
6 tasks
…microsoft/typespec into java_mgmt_premium_sample_service_client
XiaofeiCao
changed the title
XiaofeiCao
requested review from
anuchandy,
haolingdong-msft,
srnagar and
weidongxu-microsoft
as code owners
XiaofeiCao
changed the title
microsoft-github-policy-service
Bot
added
the
stale
Contributor
|
Hi @@XiaofeiCao. Your PR has had no update for 30 days and it is marked as a stale PR. If it is not updated within 30 days, the PR will automatically be closed. If you want to refresh the PR, please remove the |
Comment on lines
+119
to
+130
| // TypeSpec multi-client: check if the method group belongs to a non-primary service client | ||
| List<ServiceClient> allServiceClients = client.getServiceClients(); | ||
| if (allServiceClients != null | ||
| && allServiceClients.size() > 1 | ||
| && !methodGroupOwner.equals(primaryServiceClient.getClassName())) { | ||
| // Find the secondary service client that owns this method group | ||
| for (ServiceClient sc : allServiceClients) { | ||
| if (sc.getClassName().equals(methodGroupOwner)) { | ||
| return CodeNamer.toCamelCase(sc.getInterfaceName()) + "()"; | ||
| } | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
I don't think this part is valid for TypeSpec. For mixed-api-version, it is still just 1 client in mgmt.
For lib like resources, the separate clients are generated from different tsp compile command. So here one won't see multiple serviceClient.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
When generating premium mgmt samples from Swagger, we switched to use individual entry points in #9845. However, for multi-service scenario(appservice, resources, etc)
PolicyManager, but ratherResourceManager.ResourceManager.serviceClient().getPolicyDefinitions(), but ratherResourceManager.policyClient().getPolicyDefinitions().Solution
We'll need
For 1. Add
service-nameconfig to api-specs.json, to allow for entry point discovery. E.g.ResourceManagerinstead of defaultPolicyManager. PR: Azure/azure-sdk-for-java#48490For 2. We need secondary service client entry mapping. Fortunately, we already have
metadata-suffixthat we can use:E.g. https://github.com/Azure/azure-sdk-for-java/blob/16fffda39d14c6fc6f3f24a972814c429d46c135/sdk/resourcemanager/api-specs.json#L18
Limitation
The fix is mainly for Swagger purpose. Might need a revisit for TypeSpec multi-service.
Will log an issue if we take this approach.
About this PR