Fixes a crash when renaming import path of a JSON file

[Andarist]

fixes a crash found here #3187 (comment) (it also crashes in Strada)

[Andarist]

I have tested the same patch in Strada and renaming the from "./x/package.json" resulted in the file itself being renamed too. That's definitely a desirable outcome but I'm not exactly sure what's the codepath leading to that filename rename - given it works... I wasn't exactly inclined to dig deeper.

The alternative fix would be to handle this in the loop here:

typescript-go/internal/ls/rename.go

Lines 82 to 92 in a4325da

	for _, entry := range entries {
	uri := l.getFileNameOfEntry(entry)
	if l.UserPreferences().AllowRenameOfImportPath != core.TSTrue && entry.node != nil && ast.IsStringLiteralLike(entry.node) && ast.TryGetImportFromModuleSpecifier(entry.node) != nil {
	continue
	}
	textEdit := &lsproto.TextEdit{
	Range: l.getRangeOfEntry(entry),
	NewText: l.getTextForRename(data.OriginalNode, entry, params.NewName, ch, quotePreference),
	}
	changes[uri] = append(changes[uri], textEdit)
	}

The crash happens in getTextForRename

[gabritto]

I need to think a bit more about all this, but I think this fix is ok. We're missing support for file rename in Corsa right now (Strada's getEditsForFileRename), planning on porting that next. But I think the right behavior would be to return just a RenameFile in this case and then compute the edits in response to a willRenameFiles request from the client. So the fix looks right, but we don't have a good way right now to properly test this. I think I will leave this PR open and revisit once file rename is ported, if that's ok.