Add a setting for sending a notification on BEL#20011
Open
carlos-zamora wants to merge 2 commits intodev/cazamor/toast/basefrom
Open
Add a setting for sending a notification on BEL#20011carlos-zamora wants to merge 2 commits intodev/cazamor/toast/basefrom
carlos-zamora wants to merge 2 commits intodev/cazamor/toast/basefrom
Conversation
Member
Author
|
The only change I made was I changed the settings UI string from "Send notification" to "Desktop notification"
Separately, I noticed that the default here is
I also played around with it and I noticed this:
4. Click notification
5. Get a new Terminal window!
I double checked and we are hitting this code in terminal/src/cascadia/TerminalApp/AppCommandlineArgs.cpp Lines 1071 to 1078 in 4357c17 Shouldn't we refocus the tab/pane that sent the notification instead? @zadjii-msft thoughts? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary of the Pull Request
Targets #20010
Adds another
bellStyleflag option. This sends a windows toast notification to the user when a BEL is encounteredHeavily based on #19936
Co-authored by @zadjii-msft