Skip to content

Support for simultaneously moving multiple tabs across windows #20006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DevDengChao wants to merge 6 commits into
base: main
Choose a base branch
from
+1,690 −134
Open

Support for simultaneously moving multiple tabs across windows #20006

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1b5b1a0
Add tab drag-drop helper tests
DevDengChao Mar 19, 2026
f31d8a5
Implement multi-tab drag/drop flows
DevDengChao Mar 19, 2026
3382c4d
Stabilize tab LocalTests
DevDengChao Mar 24, 2026
278af5c
Add UIA coverage for multi-window tab drag
DevDengChao Mar 24, 2026
4f27d07
Fix PR spelling issues
DevDengChao Mar 24, 2026
6bd43e0
Trim UIA harness for review feedback
DevDengChao Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/actions/spelling/allow/apis.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,9 @@ commandlinetoargv
COPYFROMRESOURCE
cstdint
CXICON
CXSCREEN
CYICON
CYSCREEN
dataobject
debugbreak
delayimp
Expand Down Expand Up @@ -65,11 +67,13 @@ IAppearance
ICONINFO
IDirect
IInheritable
INPUTUNION
imm
iosfwd
isa
isspace
istream
keybd
KEYSELECT
LCID
LINEBREAK
Expand All @@ -86,6 +90,7 @@ MENUDATA
MENUINFO
MENUITEMINFOW
MINIMIZEBOX
MOUSEINPUT
MOUSELEAVE
mov
MULTIPLEUSE
Expand Down Expand Up @@ -135,6 +140,7 @@ RSHIFT
rvrn
SACL
schandle
schtasks
SEH
semver
serializer
Expand Down
2 changes: 0 additions & 2 deletions .github/actions/spelling/expect/expect.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -963,7 +963,6 @@ lsconfig
lstatus
lstrcmp
LTEXT
lto
ltsc
LUID
luma
Expand Down Expand Up @@ -1718,7 +1717,6 @@ titlebars
TITLEISLINKNAME
TLDP
TLEN
Tlgg
TMAE
TMPF
tmultiple
Expand Down
26 changes: 25 additions & 1 deletion src/cascadia/LocalTests_TerminalApp/CppWinrtTailored.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,31 @@ HRESULT RunOnUIThread(const TFunction& function)

auto asyncAction = d.RunAsync(winrt::Windows::UI::Core::CoreDispatcherPriority::Normal,
[&invokeResult, &function]() {
invokeResult = WEX::SafeInvoke([&]() -> bool { function(); return true; });
try
{
function();
invokeResult = S_OK;
}
catch (const winrt::hresult_error& ex)
{
invokeResult = ex.code();
WEX::Logging::Log::Comment(WEX::Common::NoThrowString().Format(
L"RunOnUIThread caught winrt::hresult_error: 0x%08x (%s)",
static_cast<unsigned int>(invokeResult),
ex.message().c_str()));
}
catch (const std::exception& ex)
{
invokeResult = E_FAIL;
WEX::Logging::Log::Comment(WEX::Common::NoThrowString().Format(
L"RunOnUIThread caught std::exception: %hs",
ex.what()));
}
catch (...)
{
invokeResult = E_UNEXPECTED;
WEX::Logging::Log::Comment(L"RunOnUIThread caught unknown exception");
}
});

asyncAction.Completed([&completedEvent](auto&&, auto&&) {
Expand Down
Loading
Loading