Conversation
0c92646 to
46b3d09
Compare
46b3d09 to
af1531f
Compare
JasonVMo
approved these changes
Apr 14, 2026
JasonVMo
left a comment
There was a problem hiding this comment.
Generally looks good. I left a comment about the macos version but given I saw it in two places, including downleveling it seems intentional.
| "react-native-safe-area-context": "^5.5.2", | ||
| "react": "19.1.4", | ||
| "react-native": "^0.81.6", | ||
| "react-native-macos": "^0.81.0", |
There was a problem hiding this comment.
Curious as to why not a later version of react-native-macos? I thought 81.0 was still on a different version of react as well.
Member
Author
There was a problem hiding this comment.
The down-leveling was because of align-deps, but you can see in yarn.lock that it resolved to a later version. It doesn't really make a difference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Split example apps to allow running React Native at different versions e.g.:
Platforms affected
Test plan
CI should pass.