petri: Plumb EfiDiagnosticsLogLevel and add INFO level test#3481
Merged
maheeraeron merged 5 commits intoMay 19, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds Petri-level configuration for EFI diagnostics verbosity and uses it in a new VMM test that verifies an INFO-level UEFI diagnostics message is observable through OpenHCL kmsg.
Changes:
- Adds
EfiDiagnosticsLogLevelto Petri UEFI configuration and a builder setter. - Maps the Petri log-level enum into OpenVMM and GED configuration paths.
- Adds a multiarch test that enables INFO diagnostics and searches kmsg for a known INFO message.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
petri/src/vm/mod.rs |
Adds the public Petri UEFI diagnostics log-level API and config field. |
petri/src/vm/openvmm/construct.rs |
Plumbs the new Petri setting into OpenVMM and OpenHCL GED config construction. |
vmm_tests/vmm_tests/tests/tests/multiarch.rs |
Adds an OpenVMM/OpenHCL UEFI test for INFO-level EFI diagnostics output. |
chris-oo
approved these changes
May 13, 2026
Member
chris-oo
left a comment
chris-oo
left a comment
There was a problem hiding this comment.
LGTM but question around testing on hyper-v
tjones60
reviewed
May 19, 2026
| generation_id_recv: None, | ||
| rtc_delta_milliseconds: 0, | ||
| efi_diagnostics_log_level: Default::default(), // TODO: Add config for tests | ||
| efi_diagnostics_log_level: match firmware |
Contributor
There was a problem hiding this comment.
nit: this is still under the heading "Disabled for VMM tests by default." I think it would make the most sense to put this match statement up near where we match the secure boot template.
tjones60
approved these changes
May 19, 2026
shenw0000
added a commit
to shenw0000/openvmm
that referenced
this pull request
May 21, 2026
cxl cxl mmio reserve root port bar for cxl component reg debug fix align debug hdm and ssdt hdm separate cxl pci mmio fix: hid and cid cedt cedt bug fix debug Add debug logs fix Revert "Add debug logs" This reverts commit 27cf831. cxl component regs fix small changes debug log debug more Revert "debug more" This reverts commit ff67454. Revert "debug log" This reverts commit f1da238. save&restore + wip: dvsec wip: dvsec cxl CXL dvsec rename port dvsec flex bus port dvsec reg locator dvsec port cxl port cxl debug debug Revert "debug" This reverts commit 29d87bf. Revert "debug" This reverts commit d77df19. test: cxl mem add type3 cxl test cxl test log fix bug fix bug leave todo AI CR More AI review more fixes fix fix fix fix more ai review CR CR CR fix merge fix more ai review fix CR CR CR petri: Plumb EfiDiagnosticsLogLevel and add INFO level test (microsoft#3481) vmm_tests: mark some tests as unstable (microsoft#3514) The following tests have been failing in CI: - x86_64__openvmm_linux_x64_virtio_blk_device - multiarch__tpm__hyperv_openhcl_uefi_x64_*_snp_use_hw_unseal - multiarch__tpm__hyperv_openhcl_uefi_x64_*_snp_skip_hw_unseal Mark them as unstable for now until a fix can be developed. CR fix CR CR CR CR
shenw0000
added a commit
to shenw0000/openvmm
that referenced
this pull request
May 21, 2026
cxl cxl mmio reserve root port bar for cxl component reg debug fix align debug hdm and ssdt hdm separate cxl pci mmio fix: hid and cid cedt cedt bug fix debug Add debug logs fix Revert "Add debug logs" This reverts commit 27cf831. cxl component regs fix small changes debug log debug more Revert "debug more" This reverts commit ff67454. Revert "debug log" This reverts commit f1da238. save&restore + wip: dvsec wip: dvsec cxl CXL dvsec rename port dvsec flex bus port dvsec reg locator dvsec port cxl port cxl debug debug Revert "debug" This reverts commit 29d87bf. Revert "debug" This reverts commit d77df19. test: cxl mem add type3 cxl test cxl test log fix bug fix bug leave todo AI CR More AI review more fixes fix fix fix fix more ai review CR CR CR fix merge fix more ai review fix CR CR CR petri: Plumb EfiDiagnosticsLogLevel and add INFO level test (microsoft#3481) vmm_tests: mark some tests as unstable (microsoft#3514) The following tests have been failing in CI: - x86_64__openvmm_linux_x64_virtio_blk_device - multiarch__tpm__hyperv_openhcl_uefi_x64_*_snp_use_hw_unseal - multiarch__tpm__hyperv_openhcl_uefi_x64_*_snp_skip_hw_unseal Mark them as unstable for now until a fix can be developed. CR fix CR CR CR CR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small PR to plumb the EfiDiagnosticsLogLevel configuration to Petri, then add a test that searches for a specific INFO level log