Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds support for analyzing logs directly from a LISA-generated Azure Storage Portal link by parsing the link, downloading blobs under the selected prefix, and then running the existing analysis flow on the downloaded local folder.
Changes:
- Add parsing logic for LISA Azure Storage portal links and extract storage identifiers + blob prefix.
- Download matching blobs locally using AAD (
DefaultAzureCredential) and analyze the downloaded directory. - Update CLI + documentation to accept
--log-link (-ll)as an alternative to--log-folders (-l).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| lisa/ai/log_agent.py | Implements link parsing, AAD-based blob download, and CLI plumbing for --log-link. |
| lisa/ai/README.md | Documents new --log-link (-ll) usage and updates required-parameter guidance. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
🤖 AI Test SelectionNo test cases were selected for this PR. |
🤖 AI Test SelectionNo test cases were selected for this PR. |
🤖 AI Test SelectionNo test cases were selected for this PR. |
🤖 AI Test SelectionNo test cases were selected for this PR. |
🤖 AI Test SelectionNo test cases were selected for this PR. |
lubaihua33
force-pushed
the
baihua/loglink
branch
from
5232ace to
7dffff8
Compare
🤖 AI Test SelectionNo test cases were selected for this PR. |
lubaihua33
force-pushed
the
baihua/loglink
branch
from
7dffff8 to
eb81f4a
Compare
🤖 AI Test SelectionNo test cases were selected for this PR. |
lubaihua33
force-pushed
the
baihua/loglink
branch
from
eb81f4a to
db2bc1e
Compare
🤖 AI Test SelectionNo test cases were selected for this PR. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
🤖 AI Test SelectionNo test cases were selected for this PR. |
|
|
||
| def _raise_missing_azure_dependency_error( | ||
| module_name: str, error: ModuleNotFoundError | ||
| ) -> None: |
There was a problem hiding this comment.
_raise_missing_azure_dependency_error never returns, it's typed as None, it should be NoReturn
Description
We can use the following command to analyze the logs in storage account.
python -m lisa.ai.log_agent analyze -ll "https://ms.portal.azure.com/#blade/Microsoft_Azure_Storage/ContainerMenuBlade/overview/storageAccountId/%2Fsubscriptions%2F0cc2a67a-58b9-4e4f-98a8-bfa46a28e896%2FresourceGroups%2Flisa_shared_resource%2Fproviders%2FMicrosoft.Storage%2FstorageAccounts%2Flisalogs6a28e896/path/lisa-logs%2FAzCertify%20Test_AzCertify%20NVMe%20Test%2020260312%2F20260312%2F20260312-091707-071%2Ftests%2F20260312-091852-338-verify_nvme_disk_controller_type"
The log link format is consistent with LISA-generated log links.
Related Issue
Type of Change
Checklist
Test Validation
Key Test Cases:
Impacted LISA Features:
AI log agent
I have run a test using a log link, and it works as expected.
Tested Azure Marketplace Images:
Test Results