Skip to content

Fix deployment issue seen in verify_hv_kvp_daemon_installed #4406

Merged
LiliDeng merged 1 commit intomainfrom
lilideng/fix_4_3_001
Apr 17, 2026
Merged

Fix deployment issue seen in verify_hv_kvp_daemon_installed #4406
LiliDeng merged 1 commit intomainfrom
lilideng/fix_4_3_001

Conversation

@LiliDeng
Copy link
Copy Markdown
Collaborator

@LiliDeng LiliDeng commented Apr 3, 2026

Description

When run verify_hv_kvp_daemon_installed with size Standard_E20bds_v6 encounter below issue:

AzureImageStandard.verify_hv_kvp_daemon_installed: FAILED deployment failed. AssertionError: actual: <class 'lisa.sut_orchestrator.azure.features.SecurityProfileSettings'>
2026-04-03 03:08:46.615[3504][INFO] lisa.RootRunner test result summary

Related Issue

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Refactoring
  • Documentation update

Checklist

  • Description is filled in above
  • No credentials, secrets, or internal details are included
  • Peer review requested (if not, add required peer reviewers after raising PR)
  • Tests executed and results posted below

Test Validation

Key Test Cases:

Impacted LISA Features:

Tested Azure Marketplace Images:
debian debian-13 13-gen2 0.20260112.2355

Test Results

Image VM Size Result
debian debian-13 13-gen2 0.20260112.2355 verify_hv_kvp_daemon_installed PASSED

@LiliDeng LiliDeng requested review from Copilot and kamalca April 3, 2026 03:11
@LiliDeng LiliDeng force-pushed the lilideng/fix_4_3_001 branch from 70b23e5 to ea7d0cd Compare April 3, 2026 03:12
@LiliDeng LiliDeng changed the title test Fix deployment issue seen in verify_hv_kvp_daemon_installed Apr 3, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes an assertion failure during feature/settings equality checks by making VirtualizationSettings.__eq__ safely handle comparisons against non-VirtualizationSettings objects (returning non-equal instead of raising).

Changes:

  • Replace a type-assert in VirtualizationSettings.__eq__ with a safe type check to avoid raising AssertionError during comparisons.

Comment thread lisa/schema.py Outdated
…strator.azure.features.SecurityProfileSettings'>
@LiliDeng LiliDeng force-pushed the lilideng/fix_4_3_001 branch from ea7d0cd to 10c5a9e Compare April 16, 2026 05:46
@github-actions
Copy link
Copy Markdown

✅ AI Test Selection — PASSED

1 test case(s) selected (view run)

Marketplace image: canonical 0001-com-ubuntu-server-jammy 22_04-lts-gen2 latest

Count
✅ Passed 1
❌ Failed 0
⏭️ Skipped 0
Total 1
Test case details
Test Case Status Time (s) Message
smoke_test (lisa_0_0) ✅ PASSED 45.039

@LiliDeng LiliDeng removed the request for review from kamalca April 17, 2026 02:19
@LiliDeng LiliDeng merged commit 045c817 into main Apr 17, 2026
61 checks passed
@LiliDeng LiliDeng deleted the lilideng/fix_4_3_001 branch April 17, 2026 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants