Skip to content

fix: normalize CRLF to LF in test/test/box_string.cpp #1557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DefaultRyan merged 3 commits into from
Apr 2, 2026
Merged

fix: normalize CRLF to LF in test/test/box_string.cpp #1557

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0f148c8
Initial plan
Copilot Apr 2, 2026
d8bcd7c
fix: convert CRLF to LF in test/test/box_string.cpp
Copilot Apr 2, 2026
cd81d46
Add workflow to check line endings in pull requests
DefaultRyan Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
106 changes: 53 additions & 53 deletions test/test/box_string.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,53 +1,53 @@
#include "pch.h"
TEST_CASE("box_string")
{
// hstring
{
winrt::hstring value = L"hstring";
auto boxed = winrt::box_value(value);
REQUIRE(winrt::unbox_value<winrt::hstring>(boxed) == L"hstring");
}
// wchar_t const* (string literal)
{
auto boxed = winrt::box_value(L"literal");
REQUIRE(winrt::unbox_value<winrt::hstring>(boxed) == L"literal");
}
// std::wstring
{
std::wstring value = L"wstring";
auto boxed = winrt::box_value(value);
REQUIRE(winrt::unbox_value<winrt::hstring>(boxed) == L"wstring");
}
// std::wstring_view (null-terminated)
{
std::wstring_view value = L"view";
auto boxed = winrt::box_value(value);
REQUIRE(winrt::unbox_value<winrt::hstring>(boxed) == L"view");
}
// std::wstring_view (not null-terminated)
// Regression test for https://github.com/microsoft/cppwinrt/issues/1527
{
std::wstring source = L"ABCDE";
std::wstring_view value(source.data(), 3); // "ABC"
auto boxed = winrt::box_value(value);
REQUIRE(winrt::unbox_value<winrt::hstring>(boxed) == L"ABC");
}
// Empty string
{
auto boxed = winrt::box_value(winrt::hstring{});
REQUIRE(winrt::unbox_value<winrt::hstring>(boxed) == L"");
}
// Empty wstring_view
{
std::wstring_view value;
auto boxed = winrt::box_value(value);
REQUIRE(winrt::unbox_value<winrt::hstring>(boxed) == L"");
}
}
#include "pch.h"

TEST_CASE("box_string")
{
// hstring
{
winrt::hstring value = L"hstring";
auto boxed = winrt::box_value(value);
REQUIRE(winrt::unbox_value<winrt::hstring>(boxed) == L"hstring");
}

// wchar_t const* (string literal)
{
auto boxed = winrt::box_value(L"literal");
REQUIRE(winrt::unbox_value<winrt::hstring>(boxed) == L"literal");
}

// std::wstring
{
std::wstring value = L"wstring";
auto boxed = winrt::box_value(value);
REQUIRE(winrt::unbox_value<winrt::hstring>(boxed) == L"wstring");
}

// std::wstring_view (null-terminated)
{
std::wstring_view value = L"view";
auto boxed = winrt::box_value(value);
REQUIRE(winrt::unbox_value<winrt::hstring>(boxed) == L"view");
}

// std::wstring_view (not null-terminated)
// Regression test for https://github.com/microsoft/cppwinrt/issues/1527
{
std::wstring source = L"ABCDE";
std::wstring_view value(source.data(), 3); // "ABC"
auto boxed = winrt::box_value(value);
REQUIRE(winrt::unbox_value<winrt::hstring>(boxed) == L"ABC");
}

// Empty string
{
auto boxed = winrt::box_value(winrt::hstring{});
REQUIRE(winrt::unbox_value<winrt::hstring>(boxed) == L"");
}

// Empty wstring_view
{
std::wstring_view value;
auto boxed = winrt::box_value(value);
REQUIRE(winrt::unbox_value<winrt::hstring>(boxed) == L"");
}
}