Parameterize NAS Parallel Benchmark profile for ThreadCount and Bench…#662
Merged
Parameterize NAS Parallel Benchmark profile for ThreadCount and Bench…#662
Conversation
…markclass - Add ThreadCount profile parameter (default: LogicalCoreCount - 2) to replace hard-coded Environment.ProcessorCount for OMP_NUM_THREADS. Uses ParametersOn guard to set ThreadCount=1 on systems with 2 or fewer cores. - Add Benchmarkclass profile parameter (default: C) to replace previously hard-coded class D benchmark references. IS and DC benchmarks remain pinned to classes C and B respectively due to NPB limitations. - Add ThreadCount property to NASParallelBenchClientExecutor with fallback to Environment.ProcessorCount if not specified. - Add unit test for custom ThreadCount override. - Add Resource Requirements section to documentation with memory estimation formulas and per-class sizing table. - Document ThreadCount, Benchmarkclass parameters, and pinned benchmark classes in workload profiles documentation.
- Fix NASParallelBenchProfileTests to derive expected ThreadCount from
mock CpuInfo.LogicalProcessorCount rather than Environment.ProcessorCount,
matching how the ProfileExpressionEvaluator resolves {LogicalCoreCount}.
- Remove dc benchmark action from profile (dc not reliably compiled).
- Remove dc.B.x from expected commands and expectedFiles in tests.
- Deduplicate X64/Arm64 test branches using platformDir variable.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
ericavella
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…markclass