Enabling madvise syscalls on v6.18#134
Open
dpaliulis-msft wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR enables the kernel’s madvise()/fadvise() syscalls in the OpenHCL v6.18 HCL kernel configs to allow MiMalloc decommit paths to actually decommit memory (addressing the user-mode memory growth/leak behavior referenced from PR #133).
Changes:
- Enable
CONFIG_ADVISE_SYSCALLS=yfor the x64 HCL kernel config. - Enable
CONFIG_ADVISE_SYSCALLS=yfor the arm64 HCL kernel config.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Microsoft/hcl-x64.config | Turns on CONFIG_ADVISE_SYSCALLS to enable madvise()/fadvise() on x64. |
| Microsoft/hcl-arm64.config | Turns on CONFIG_ADVISE_SYSCALLS to enable madvise()/fadvise() on arm64. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
smalis-msft
approved these changes
May 13, 2026
benhillis
approved these changes
May 13, 2026
Collaborator
|
The config change has minimal effect on the kernel binary size:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding user-mode memory leak fix from PR 133 to v6.18.