Exit cleanly when i-PI drops the connections rather than erroring out.#48
Open
Exit cleanly when i-PI drops the connections rather than erroring out.#48
Conversation
This prints the final stats, and is in general cleaner.
Member
|
Shouldn't this be sent upstream instead of here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prints the final stats, and is in general cleaner.
Summary
fix_ipi exits with an error when the server disconnects. this PR implements a cleaner exit mechanism, allowing among other things to print out the runtime stats that LAMMPS usually prints at the end of a simulation.
Author(s)
Michele Ceriotti, EPFL, michele.ceriotti@gmail.com
Licensing
By submitting this pull request, I agree, that my contribution will be included in LAMMPS and redistributed under either the GNU General Public License version 2 (GPL v2) or the GNU Lesser General Public License version 2.1 (LGPL v2.1).
Artificial Intelligence (AI) Tools Usage
By submitting this pull request, I confirm that I did NOT use any AI tools to generate
all or parts of the code and modifications in this pull request.
Backward Compatibility
This should be fully backward compatible.
Implementation Notes
This simply sets a flag when the socket drops the connection, which is picked up at the end of the verlet steps to trigger the usual LAMMPS exit path.
Post Submission Checklist