Skip to content

Add ascender/descender proto defs, logic, & tests#12

Open
jseppi wants to merge 2 commits intomasterfrom
add-ascender-descender
Open

Add ascender/descender proto defs, logic, & tests#12
jseppi wants to merge 2 commits intomasterfrom
add-ascender-descender

Conversation

@jseppi
Copy link
Copy Markdown

@jseppi jseppi commented Nov 25, 2019

Closes #11

@springmeyer for review, please

cc @tristen

@jseppi jseppi requested a review from springmeyer November 25, 2019 16:19
@jseppi jseppi self-assigned this Nov 25, 2019
@springmeyer
Copy link
Copy Markdown

PR seems straightforward, so 👍

If any font has a different ascender or descender value, then the composite will have its value set to 0 (which will enable falling back to the hard-coded default values in mapbox-gl-js and mapbox-gl-native).

I have some questions about this, will comment at #11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handle fontstack ascender/descender metadata

2 participants