Add ascender/descender proto defs, logic, & tests#12
Open
Conversation
springmeyer
approved these changes
Nov 26, 2019
|
PR seems straightforward, so 👍
I have some questions about this, will comment at #11 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11
ascenderanddescenderfields toglyphs.prototo match those in Expose ascender/descender metadata properties in protobuf node-fontnik#160ascenderanddescenderas described in Handle fontstack ascender/descender metadata #11:ascenderordescender, then the composite will have that value.ascenderordescendervalue, then the composite will have its value set to 0 (which will enable falling back to the hard-coded default values in mapbox-gl-js and mapbox-gl-native).node-fontnikversion in Expose ascender/descender metadata properties in protobuf node-fontnik#160 so that they haveascenderanddescendervalues set@springmeyer for review, please
cc @tristen