Fix conflict between BBCodePlus and MantisCoreFormatting Markdown#112
Open
bcp-software wants to merge 1 commit intomantisbt-plugins:masterfrom
Open
Fix conflict between BBCodePlus and MantisCoreFormatting Markdown#112bcp-software wants to merge 1 commit intomantisbt-plugins:masterfrom
bcp-software wants to merge 1 commit intomantisbt-plugins:masterfrom
Conversation
When MantisCoreFormatting's Markdown mode is active, BBCodePlus was calling string_strip_hrefs() which destroyed links rendered by the Markdown parser (e.g. [text](url) -> <a href="url">text</a> -> "text"). Skip string_strip_hrefs when Markdown is active so Markdown-generated links survive BBCodePlus's HTML->BBCode->HTML round-trip intact. BBCode [tag] syntax and Markdown **syntax** are orthogonal and do not conflict, so both plugins can be active simultaneously. This allows sites with a mix of legacy BBCode tickets and newer Markdown tickets to display correctly without disabling either plugin. Removes the conflict warning in content_begin() as it is no longer needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When MantisCoreFormatting's Markdown mode is active, BBCodePlus was calling string_strip_hrefs() which destroyed links rendered by the Markdown parser (e.g. text -> text -> "text").
Skip string_strip_hrefs when Markdown is active so Markdown-generated links survive BBCodePlus's HTML->BBCode->HTML round-trip intact.
BBCode [tag] syntax and Markdown syntax are orthogonal and do not conflict, so both plugins can be active simultaneously. This allows sites with a mix of legacy BBCode tickets and newer Markdown tickets to display correctly without disabling either plugin.
Removes the conflict warning in content_begin() as it is no longer needed.