feat(cli): add multicast groups to status (#3447)#3448
Open
bgm-malbeclabs wants to merge 2 commits intomainfrom
Open
feat(cli): add multicast groups to status (#3447)#3448bgm-malbeclabs wants to merge 2 commits intomainfrom
bgm-malbeclabs wants to merge 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds multicast publisher/subscriber group visibility to the doublezero status CLI by enriching daemon /v2/status responses with multicast group codes and rendering them as a new “Multicast Groups” column (with corresponding e2e + unit test updates).
Changes:
- Extend daemon
/v2/statusenriched service status withmulticast_groups.publisher/multicast_groups.subscriber. - Update CLI
statusoutput (table + JSON) to include a “Multicast Groups” column formatted asP:<code>,S:<code>. - Update unit tests and e2e golden fixtures to validate the new field/column.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| e2e/multicast_test.go | Passes expected multicast group string into status fixture rendering for multicast scenarios. |
| e2e/fixtures/multicast/doublezero_status_disconnected.tmpl | Updates expected status table to include the new “Multicast Groups” column. |
| e2e/fixtures/multicast/doublezero_status_connected_subscriber.tmpl | Adds “Multicast Groups” column and renders expected subscriber groups. |
| e2e/fixtures/multicast/doublezero_status_connected_publisher.tmpl | Adds “Multicast Groups” column and renders expected publisher groups. |
| e2e/fixtures/ibrl/doublezero_status_disconnected.tmpl | Updates expected status output to include the new column (empty for IBRL). |
| e2e/fixtures/ibrl/doublezero_status_connected.tmpl | Updates expected connected IBRL status output to include the new column (empty). |
| e2e/fixtures/ibrl_with_allocated_addr/doublezero_status_disconnected.tmpl | Updates expected disconnected output to include the new column (empty). |
| e2e/fixtures/ibrl_with_allocated_addr/doublezero_status_connected.tmpl | Updates expected connected output to include the new column (empty). |
| client/doublezerod/internal/manager/reconciler_test.go | Extends enrichment tests to assert publisher/subscriber multicast group codes. |
| client/doublezerod/internal/manager/http.go | Adds multicast_groups to enriched /v2/status output and populates it from on-chain program data. |
| client/doublezero/src/servicecontroller.rs | Adds MulticastGroups + deserialization defaults to client-side /v2/status types. |
| client/doublezero/src/command/status.rs | Adds display formatting + column plumbing + tests for multicast groups in status. |
| CHANGELOG.md | Notes the new status multicast group reporting behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR adds multicast groups to the dz
statuscommand. Sample output is below:Table mode:
JSON mode:
{ "multicast_groups": { "publisher": ["solana-lv"], "subscriber": ["solana-ams"] } }Testing Verification
Closes #3447