Skip to content

feat(cli): add multicast groups to status (#3447)#3448

Open
bgm-malbeclabs wants to merge 2 commits intomainfrom
bgm/cli_status_groups
Open

feat(cli): add multicast groups to status (#3447)#3448
bgm-malbeclabs wants to merge 2 commits intomainfrom
bgm/cli_status_groups

Conversation

@bgm-malbeclabs
Copy link
Copy Markdown
Contributor

@bgm-malbeclabs bgm-malbeclabs commented Apr 3, 2026

Summary of Changes

This PR adds multicast groups to the dz status command. Sample output is below:

Table mode:

| Session Status | ... | Multicast Groups         |
|----------------|-----|--------------------------|
| BGP Session Up | ... | P:solana-lv,S:solana-ams |

JSON mode:

{
  "multicast_groups": {
    "publisher": ["solana-lv"],
    "subscriber": ["solana-ams"]
  }
}

Testing Verification

  • e2e updated with new fixtures
  • tests added to validate new output

Closes #3447

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds multicast publisher/subscriber group visibility to the doublezero status CLI by enriching daemon /v2/status responses with multicast group codes and rendering them as a new “Multicast Groups” column (with corresponding e2e + unit test updates).

Changes:

  • Extend daemon /v2/status enriched service status with multicast_groups.publisher / multicast_groups.subscriber.
  • Update CLI status output (table + JSON) to include a “Multicast Groups” column formatted as P:<code>,S:<code>.
  • Update unit tests and e2e golden fixtures to validate the new field/column.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
e2e/multicast_test.go Passes expected multicast group string into status fixture rendering for multicast scenarios.
e2e/fixtures/multicast/doublezero_status_disconnected.tmpl Updates expected status table to include the new “Multicast Groups” column.
e2e/fixtures/multicast/doublezero_status_connected_subscriber.tmpl Adds “Multicast Groups” column and renders expected subscriber groups.
e2e/fixtures/multicast/doublezero_status_connected_publisher.tmpl Adds “Multicast Groups” column and renders expected publisher groups.
e2e/fixtures/ibrl/doublezero_status_disconnected.tmpl Updates expected status output to include the new column (empty for IBRL).
e2e/fixtures/ibrl/doublezero_status_connected.tmpl Updates expected connected IBRL status output to include the new column (empty).
e2e/fixtures/ibrl_with_allocated_addr/doublezero_status_disconnected.tmpl Updates expected disconnected output to include the new column (empty).
e2e/fixtures/ibrl_with_allocated_addr/doublezero_status_connected.tmpl Updates expected connected output to include the new column (empty).
client/doublezerod/internal/manager/reconciler_test.go Extends enrichment tests to assert publisher/subscriber multicast group codes.
client/doublezerod/internal/manager/http.go Adds multicast_groups to enriched /v2/status output and populates it from on-chain program data.
client/doublezero/src/servicecontroller.rs Adds MulticastGroups + deserialization defaults to client-side /v2/status types.
client/doublezero/src/command/status.rs Adds display formatting + column plumbing + tests for multicast groups in status.
CHANGELOG.md Notes the new status multicast group reporting behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@bgm-malbeclabs bgm-malbeclabs requested a review from packethog April 3, 2026 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add user mcast groups to status

2 participants