Skip to content

Add block information to the instrumentation job metadata #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
machshev merged 1 commit into from
May 18, 2026
Merged

Add block information to the instrumentation job metadata #194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/dvsim/instrumentation/metadata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ def get_job_data(self) -> Mapping[str, JobInstrumentationMetadata]:
job_type=spec.job_type,
target=spec.target,
tool=spec.tool.name,
block=spec.block.name,
Copy link
Copy Markdown
Collaborator

@machshev machshev May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe rather than flattening just use composition and take the whole block meta data spec.block... that way if we update the block definition in some other way then this is constant without having to sync everything.

It does mean more information though and increased serialisation size perhaps?

Copy link
Copy Markdown
Contributor Author

@AlexJones0 AlexJones0 May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I agree, I'm conscious that any fields added here directly impact the instrumentation size by a fair amount, so I'm trying to avoid bloating the output too much.

I think long-term we should split up the block info (IPMeta) a bit more to separate block name info from commit/revision info, but I suspect that will be a slightly larger task due to the number of involved areas, and so I'd prefer if that happened after this instrumentation reporting work was merged. WDYT?

block_variant=spec.block.variant,
backend=spec.backend,
dependencies=list(spec.dependencies),
status=status_str,
Expand Down
2 changes: 2 additions & 0 deletions src/dvsim/instrumentation/records.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@ class JobInstrumentationMetadata(JobMetrics):
job_type: str
target: str
tool: str
block: str
block_variant: str | None
backend: str | None
dependencies: list[str]
status: str
Expand Down
Loading