[TestSuiteBuilder] Updating the test-suite clobber step#75
Open
[TestSuiteBuilder] Updating the test-suite clobber step#75
Conversation
This change modifies the step that clobbers the build directory of the llvm-test-suite to use the standardized `f.addStep(steps.RemoveDirectory())` that the base class, UnifiedTreeBuilder, uses instead of the more explicit `f.addStep(ShellCommand(command=['rm', '-rf']))`
lei137
approved these changes
Nov 30, 2023
Contributor
lei137
left a comment
lei137
left a comment
There was a problem hiding this comment.
LGTM
Minor indentation nit.
Comment on lines
+34
to
+40
| f.addStep(steps.RemoveDirectory( | ||
| name='Clean Test Suite Build dir' % test_suite_workdir, | ||
| dir=test_suite_workdir, | ||
| haltOnFailure=False, | ||
| flunkOnFailure=False, | ||
| doStepIf=cleanBuildRequested, | ||
| )) |
Contributor
There was a problem hiding this comment.
nit: Should we keep to the same indentation here as other files? eg .
Suggested change
| f.addStep(steps.RemoveDirectory( | |
| name='Clean Test Suite Build dir' % test_suite_workdir, | |
| dir=test_suite_workdir, | |
| haltOnFailure=False, | |
| flunkOnFailure=False, | |
| doStepIf=cleanBuildRequested, | |
| )) | |
| f.addStep(steps.RemoveDirectory(name='Clean Test Suite Build dir' % test_suite_workdir, | |
| dir=test_suite_workdir, | |
| haltOnFailure=False, | |
| flunkOnFailure=False, | |
| doStepIf=cleanBuildRequested, | |
| )) |
Member
There was a problem hiding this comment.
I think the indenting would probably start under name=, like the other steps.
gkistanova
reviewed
Dec 18, 2023
Contributor
gkistanova
left a comment
gkistanova
left a comment
There was a problem hiding this comment.
The patch looks fine with a small thing to fix.
| # The default value of cleanBuildRequested is TRUE as we should always | ||
| # clobber the build directory to test each freshly built compiler. | ||
| f.addStep(steps.RemoveDirectory( | ||
| name='Clean Test Suite Build dir' % test_suite_workdir, |
Contributor
There was a problem hiding this comment.
Could you use Python3 .format() here instead, please?
amy-kwan
approved these changes
Jan 2, 2024
Comment on lines
+34
to
+40
| f.addStep(steps.RemoveDirectory( | ||
| name='Clean Test Suite Build dir' % test_suite_workdir, | ||
| dir=test_suite_workdir, | ||
| haltOnFailure=False, | ||
| flunkOnFailure=False, | ||
| doStepIf=cleanBuildRequested, | ||
| )) |
Member
There was a problem hiding this comment.
I think the indenting would probably start under name=, like the other steps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change modifies the step that clobbers the build directory of the llvm-test-suite to use the standardized
f.addStep(steps.RemoveDirectory())that the base class, UnifiedTreeBuilder, uses instead of the more explicitf.addStep(ShellCommand(command=['rm', '-rf']))