-
Notifications
You must be signed in to change notification settings - Fork 110
fix: dispose track publication handles on participant disconnect #634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
LautaroPetaccio
wants to merge
8
commits into
livekit:main
Choose a base branch
from
LautaroPetaccio:fix/dispose-track-publications-on-disconnect
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+100
−0
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
9c95289
fix: dispose track publication handles on participant disconnect
LautaroPetaccio cfbd69e
chore: add changeset
LautaroPetaccio db3177d
chore: add changeset
LautaroPetaccio 90007c6
chore: remove duplicate changeset
LautaroPetaccio 240eb06
fix: emit ParticipantDisconnected before disposing handles
LautaroPetaccio 15117b4
fix: dispose FfiHandles eagerly on trackUnpublished
LautaroPetaccio 251b6d5
refactor: remove redundant disposal sweep from participantDisconnected
LautaroPetaccio 7605e1c
chore: merge livekit/main
LautaroPetaccio File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@livekit/rtc-node': patch | ||
| --- | ||
|
|
||
| Dispose track publication FfiHandles on participant disconnect to prevent FD leaks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 participantDisconnected handler does not dispose remaining publication FfiHandles, causing FD leaks if trackUnpublished events are skipped
The PR's stated intent is to prevent FD leaks from track publication handles on participant disconnect, but the disposal is only added in the
trackUnpublishedhandler (room.ts:451). TheparticipantDisconnectedhandler (room.ts:408-416) removes the participant fromremoteParticipantswithout disposing any remaining publicationffiHandles. IftrackUnpublishedevents don't fire for every track beforeparticipantDisconnected(e.g., during abrupt disconnects or server-side removals), those handles will leak — the exact scenario the PR aims to fix. The test at line 562 assertstrackPublications.size === 0, validating only the happy path wheretrackUnpublishedprecedesparticipantDisconnected. A defensive cleanup loop in theparticipantDisconnectedhandler would close this gap.(Refers to lines 410-413)
Was this helpful? React with 👍 or 👎 to provide feedback.