Skip to content

fix manifest start_url when using SUBFOLDER#162

Merged
thelamer merged 1 commit into
linuxserver:masterfrom
Briffou:master
May 22, 2026
Merged

fix manifest start_url when using SUBFOLDER#162
thelamer merged 1 commit into
linuxserver:masterfrom
Briffou:master

Conversation

@Briffou
Copy link
Copy Markdown
Contributor

@Briffou Briffou commented May 21, 2026

linuxserver.io


  • I have read the contributing guideline and understand that I have made the correct modifications

Description:

Fix the start_url parameter for the PWA when SUBFOLDER is used.

Benefits of this PR and context:

When using the SUBFOLDER parameter of the docker image, the resulting PWA was using the wrong url when starting.

How Has This Been Tested?

docker run --rm -it \
  --shm-size=1gb \
  -p 3001:3001 \
  --device /dev/dri \
  -e SUBFOLDER=/test/ \
  -e PIXELFLUX_WAYLAND=true \
  -e AUTO_GPU=true \
  test_pwa_subfolder

Then install the PWA (tested on chrome 131.0.6778.69, Fedora 44) , and launch it. I checked the resulting manifest.json to look at the start_url: /test/ parameter.

I also tested without -e SUBFOLDER=/test/.

Source / References:

https://developer.mozilla.org/en-US/docs/Web/Progressive_web_apps/Manifest/Reference/start_url

(by the way, didn't find the changelog in the repo)

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! Be sure to follow the pull request template!

@thelamer
Copy link
Copy Markdown
Member

Yeah baseimages are the wild west kind of there is no official versioning or changelogs:
https://github.com/linuxserver/docker-baseimage-selkies/commits/master/.

Might need to re-think that for Selkies, though clearly the goal is to never make breaking changes.
I'll get this into all the branches tomorrow.

thelamer added a commit that referenced this pull request May 22, 2026
thelamer added a commit that referenced this pull request May 22, 2026
thelamer added a commit that referenced this pull request May 22, 2026
thelamer added a commit that referenced this pull request May 22, 2026
thelamer added a commit that referenced this pull request May 22, 2026
thelamer added a commit that referenced this pull request May 22, 2026
@thelamer thelamer self-requested a review May 22, 2026 12:28
@LinuxServer-CI LinuxServer-CI moved this from PRs to PRs Ready For Team Review in Issue & PR Tracker May 22, 2026
@github-project-automation github-project-automation Bot moved this from PRs Ready For Team Review to PRs Approved in Issue & PR Tracker May 22, 2026
@thelamer thelamer merged commit 2669a15 into linuxserver:master May 22, 2026
5 checks passed
@LinuxServer-CI LinuxServer-CI moved this from PRs Approved to Done in Issue & PR Tracker May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants