Ensure default filters take priority over user accounts#547
Open
FrostBird347 wants to merge 3 commits into
Open
Ensure default filters take priority over user accounts#547FrostBird347 wants to merge 3 commits into
FrostBird347 wants to merge 3 commits into
Conversation
exclude_list_default_extra used to take priority over exclude_list_user, this is no longer the case and so there is no reason to keep the list seperate from exclude_list_default Also note that exclude_list_default_extra used to be ignored when running --clone, however that apparently isn't a supported feature anymore according to https://github.com/linuxmint/timeshift/blob/aaff762ce2dc42e799176fff5d6effb8063fcb67/src/AppConsole.vala#L379 and just gets treated as --restore
All other user specified filters are kept at top priority so if a user still wants to back up their cache folder they can still add a specific filter for that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #545 by moving user home directory filters to be placed after the defaults, I also removed
exclude_list_default_extraas it was made redundant in #342.Since this only moves the home directory entries listed under the "Users" tab in the settings page, all other custom filters still take priority over the defaults.