Open
Conversation
…s methods, also got rid of comments in ContinuousEvaluator as we are using launcher now.
…o take a JSONObject and filename.
…ng individual satisfaction
…mpleAcquaintancestest that uses it, adjusted launcher to use the flag as well
… go into the newly designed data file
…a TODO for next steps
… so that ground truth map, ground rule map, ground atom map, and rule map can all be arguments to the same method.
…inal push of new data file logic
…ill not be pushed until then. Changed the implementation for creating the new data file. Did some additional cleanup such as ordering imports, removing un-needed code, and style. Also added back parent rule weights to the data file instead of just booleans.
eriq-augustine
requested changes
Sep 10, 2020
Member
eriq-augustine
left a comment
eriq-augustine
left a comment
There was a problem hiding this comment.
Nice, making good progress with the streaming JSON.
…there was a term that exactly matched it
…ed as doubles instead of ints as that more closely follows the inputed data
…paces written to JSON, included error message including the path for an IOException for path file, and some style changes.
eriq-augustine
requested changes
Sep 15, 2020
Member
eriq-augustine
left a comment
eriq-augustine
left a comment
There was a problem hiding this comment.
Making some good progress.
Remember that I will typically only make a comment once, but it apples to all files.
(E.g. one letter variable names and missing spaces before braces.)
Aaron, can you review the comments that I have previously given Tarun.
There are a bunch apply, and we (you and I) have just not gone over yet.
…to avoid many access logs.
…anges, and renamed last few variables of visualization to model collection.
This was referenced Aug 16, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.