Skip to content

chore: Sync account schemas#334

Open
lightspark-copybara[bot] wants to merge 1 commit intomainfrom
auto/sync-grid-schemas-20260410-230029
Open

chore: Sync account schemas#334
lightspark-copybara[bot] wants to merge 1 commit intomainfrom
auto/sync-grid-schemas-20260410-230029

Conversation

@lightspark-copybara
Copy link
Copy Markdown
Contributor

Auto-synced account schemas.

These schemas are generated from VASP adapter field definitions in sparkcore.

Synced schemas:

  • common/ — per-currency account info, beneficiary, and payment account schemas
  • common/PaymentInstructions.yaml — payment instructions oneOf (new currencies added)
  • external_accounts/ — per-currency external account schemas (reference common/)

Please review the changes before merging.

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 10, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
grid-flow-builder Ready Ready Preview, Comment Apr 10, 2026 11:01pm

Request Review

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 10, 2026

✱ Stainless preview builds

This PR will update the grid SDKs with the following commit messages.

kotlin

feat(api): add bankName to BDT/COP/EGP/GHS/GTQ/JMD/PKR/USD account models

openapi

feat(api): add required bankName field to external account info models

python

feat(api): add bank_name field to account info models

typescript

feat(api): add bankName field to BDT/COP/EGP/GHS/GTQ/JMD/PKR/USD account types

Edit this comment to update them. They will appear in their respective SDK's changelogs.

grid-openapi studio · code · diff

Your SDK build had at least one "note" diagnostic, but this did not represent a regression.
generate ✅

grid-kotlin studio · code · diff

Your SDK build had at least one "note" diagnostic, but this did not represent a regression.
generate ✅build ✅ (prev: build ⏭️) → lint ✅ (prev: lint ⏭️) → test ✅

⚠️ grid-python studio · code · diff

Your SDK build had a failure in the lint CI job, which is a regression from the base state.
generate ✅build ✅ (prev: build ⏭️) → lint ❗ (prev: lint ⏭️) → test ✅

pip install https://pkg.stainless.com/s/grid-python/1fa3c068b3ab747f96e48e31b2123ed59e61f67c/grid-0.0.1-py3-none-any.whl
⚠️ grid-typescript studio · code · diff

Your SDK build had a failure in the lint CI job, which is a regression from the base state.
generate ✅build ✅ (prev: build ⏭️) → lint ❗ (prev: lint ⏭️) → test ✅

npm install https://pkg.stainless.com/s/grid-typescript/a733cc8f4444ad18e76c52efb98bef22b862dcf5/dist.tar.gz

This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push.
If you push custom code to the preview branch, re-run this workflow to update the comment.
Last updated: 2026-04-10 23:05:37 UTC

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Apr 10, 2026

Greptile Summary

This PR adds bankName as a required field (with minLength: 1, maxLength: 255) to eight currency-specific *AccountInfo schemas (BDT, COP, EGP, GHS, GTQ, JMD, PKR, USD), synced from VASP adapter field definitions in sparkcore. Both generated bundles (openapi.yaml and mintlify/openapi.yaml) are correctly regenerated via make build, and the existing USD path-level examples already include bankName, so no example updates are needed.

Confidence Score: 5/5

This PR is safe to merge — changes are clean, consistent, and the build artifacts are correctly regenerated.

All schema changes are uniform and correctly structured. Generated bundles match the source. No broken examples, no missing constraints, no logic issues. All remaining observations are P2 or lower.

No files require special attention.

Important Files Changed

Filename Overview
openapi/components/schemas/common/BdtAccountInfo.yaml Adds bankName as a required field with proper string constraints (minLength 1, maxLength 255); correctly positioned in required list and properties.
openapi/components/schemas/common/CopAccountInfo.yaml Adds bankName as a required field with consistent placement and constraints, matching the pattern used across other currency schemas in this PR.
openapi/components/schemas/common/EgpAccountInfo.yaml Adds bankName as a required field; consistent with the rest of the PR changes.
openapi/components/schemas/common/GhsAccountInfo.yaml Adds bankName as a required field; consistent with the rest of the PR changes.
openapi/components/schemas/common/GtqAccountInfo.yaml Adds bankName as a required field; consistent with the rest of the PR changes.
openapi/components/schemas/common/JmdAccountInfo.yaml Adds bankName as a required field; consistent with the rest of the PR changes.
openapi/components/schemas/common/PkrAccountInfo.yaml Adds bankName as a required field; consistent with the rest of the PR changes.
openapi/components/schemas/common/UsdAccountInfo.yaml Adds bankName as a required field appended at the end of both required list and properties; minor ordering difference vs. other schemas but functionally correct, and existing USD examples in path files already include bankName.
openapi.yaml Correctly regenerated bundle reflecting all bankName additions across all affected currency schemas.
mintlify/openapi.yaml Correctly regenerated Mintlify copy of the bundle; consistent with openapi.yaml.

Entity Relationship Diagram

%%{init: {'theme': 'neutral'}}%%
erDiagram
    BdtAccountInfo {
        string accountType
        array paymentRails
        string bankName "NEW - required"
        string accountNumber
        string branchCode
        string phoneNumber
        string swiftCode
    }
    CopAccountInfo {
        string accountType
        array paymentRails
        string bankName "NEW - required"
        string accountNumber
        string bankAccountType
        string phoneNumber
    }
    EgpAccountInfo {
        string accountType
        array paymentRails
        string bankName "NEW - required"
        string accountNumber
    }
    GhsAccountInfo {
        string accountType
        array paymentRails
        string bankName "NEW - required"
        string accountNumber
        string phoneNumber
    }
    GtqAccountInfo {
        string accountType
        array paymentRails
        string bankName "NEW - required"
        string accountNumber
        string phoneNumber
    }
    JmdAccountInfo {
        string accountType
        array paymentRails
        string bankName "NEW - required"
        string accountNumber
        string branchCode
        string bankAccountType
    }
    PkrAccountInfo {
        string accountType
        array paymentRails
        string bankName "NEW - required"
        string accountNumber
        string phoneNumber
    }
    UsdAccountInfo {
        string accountType
        array paymentRails
        string accountNumber
        string routingNumber
        string bankName "NEW - required"
    }
Loading

Reviews (1): Last reviewed commit: "chore: Sync account schemas" | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants