Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✱ Stainless preview buildsThis PR will update the kotlin openapi python typescript Edit this comment to update them. They will appear in their respective SDK's changelogs. ✅ grid-kotlin studio · code · diff
✅ grid-openapi studio · code · diff
✅ grid-python studio · code · diff
✅ grid-typescript studio · code · diff
This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push. |
Greptile SummaryThis PR consolidates four independent inline Confidence Score: 5/5Safe to merge — clean enum consolidation with no remaining old values anywhere in the spec or docs. All four schemas are updated consistently, no old suffixed values remain in the codebase, the bundled outputs match the source changes, and lint passes. Previous P2 comments about bare- No files require special attention.
|
| Filename | Overview |
|---|---|
| openapi/components/schemas/crypto/CryptoNetwork.yaml | New shared enum schema with 6 values; description includes a clear mainnet/sandbox mapping table. |
| openapi/components/schemas/crypto/EstimateCryptoWithdrawalFeeRequest.yaml | Replaced inline string definition for cryptoNetwork with $ref to shared enum; field remains required. |
| openapi/components/schemas/external_accounts/ExternalAccount.yaml | Swapped cryptoNetwork to use shared $ref; field is correctly kept optional (not in required array). |
| openapi/components/schemas/external_accounts/ExternalAccountCreateRequest.yaml | Swapped cryptoNetwork to use shared $ref; field is correctly optional in the request schema. |
| openapi/components/schemas/quotes/RealtimeFundingQuoteSource.yaml | Uses allOf + $ref pattern with a property-level description — the best pattern of the four updated schemas. |
| openapi/paths/crypto/crypto_estimate-withdrawal-fee.yaml | Example value updated from old suffixed format to SOLANA to match new enum. |
| openapi.yaml | Bundled output correctly reflects the new CryptoNetwork component and all four updated schema references. |
| mintlify/openapi.yaml | Mintlify copy of the bundle updated to match; generated by make build. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[CryptoNetwork.yaml\nenum: BITCOIN, ETHEREUM,\nSOLANA, BASE, SPARK, LIGHTNING] --> B[EstimateCryptoWithdrawalFeeRequest\ncryptoNetwork: required]
A --> C[ExternalAccount\ncryptoNetwork: optional]
A --> D[ExternalAccountCreateRequest\ncryptoNetwork: optional]
A --> E[RealtimeFundingQuoteSource\ncryptoNetwork: optional]
F[API Environment] -->|production| G[mainnet variant\ne.g. BITCOIN → Bitcoin mainnet]
F -->|sandbox| H[testnet/devnet variant\ne.g. BITCOIN → Bitcoin testnet]
Reviews (2): Last reviewed commit: "feat: change cryptoNetwork from string t..." | Re-trigger Greptile
openapi/components/schemas/external_accounts/ExternalAccountCreateRequest.yaml
Show resolved
Hide resolved
…postfix Creates a shared CryptoNetwork enum schema with values: BITCOIN, ETHEREUM, SOLANA, BASE, SPARK, LIGHTNING. The environment (mainnet/testnet) is now determined by which API environment the request targets, removing the _MAINNET/_TESTNET/_DEVNET/_REGTEST suffixes. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
9528bcb to
b09cf0e
Compare
Summary
CryptoNetworkenum schema with values:BITCOIN,ETHEREUM,SOLANA,BASE,SPARK,LIGHTNING_MAINNET/_TESTNET/_DEVNET/_REGTESTsuffixescryptoNetworkto use the shared enum (EstimateCryptoWithdrawalFeeRequest,ExternalAccount,ExternalAccountCreateRequest,RealtimeFundingQuoteSource)sparklib/money/crypto_network.pyTest plan
make build— OpenAPI bundle succeedsmake lint-openapi— validation passes🤖 Generated with Claude Code