Fix misleading comment on counterparty_commitment_txn_on_chain insert#4530
Fix misleading comment on counterparty_commitment_txn_on_chain insert#4530joostjager wants to merge 1 commit intolightningdevkit:mainfrom
Conversation
The comment claimed this insert "isn't useful yet" and was only a safety measure for a watchtower race. In practice it is also used by provide_payment_preimage to look up the commitment number when a preimage arrives after the counterparty commitment tx is confirmed. AI tools were used in preparing this commit.
|
👋 Thanks for assigning @TheBlueMatt as a reviewer! |
|
I've now reviewed the full context. The PR is a comment-only change. Let me verify the new comment's claims are accurate:
The new comment is factually correct and more informative than the old one. This is a clean, comment-only change with no code modifications. No issues found. |
The comment claimed this insert "isn't useful yet" and was only a safety measure for a watchtower race. In practice it is also used critically by provide_payment_preimage to look up the commitment number when a preimage arrives after the counterparty commitment tx is confirmed.