Skip to content

Re-pin idna_adapter to for MSRV builds#867

Merged
tnull merged 1 commit intolightningdevkit:mainfrom
tnull:2026-04-readd-idna-adapter-pin
Apr 2, 2026
Merged

Re-pin idna_adapter to for MSRV builds#867
tnull merged 1 commit intolightningdevkit:mainfrom
tnull:2026-04-readd-idna-adapter-pin

Conversation

@tnull
Copy link
Copy Markdown
Collaborator

@tnull tnull commented Apr 2, 2026

.. we previously dropped the pin when moving MSRV to 1.85, but it seems that is not sufficient anymore..

.. we previously dropped the pin when moving MSRV to 1.85, but it seems
that is not sufficient anymore..
@ldk-reviews-bot
Copy link
Copy Markdown

ldk-reviews-bot commented Apr 2, 2026

👋 Thanks for assigning @joostjager as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@tnull tnull requested a review from joostjager April 2, 2026 11:22
Copy link
Copy Markdown
Contributor

@joostjager joostjager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, assuming build passes

@tnull tnull merged commit 253dc13 into lightningdevkit:main Apr 2, 2026
16 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants