Skip to content

feat: upstream unusedDecidableInType linter#13688

Merged
wkrozowski merged 43 commits into
leanprover:masterfrom
wkrozowski:wojciech/unusedDecidableInType
May 14, 2026
Merged

feat: upstream unusedDecidableInType linter#13688
wkrozowski merged 43 commits into
leanprover:masterfrom
wkrozowski:wojciech/unusedDecidableInType

Conversation

@wkrozowski
Copy link
Copy Markdown
Contributor

@wkrozowski wkrozowski commented May 8, 2026 •
edited
Loading

This PR upstreams unusedDecidableInType linter from mathlib.

Stacked on top of #11313.

thorimur and others added 30 commits April 23, 2026 15:03
@thorimur
feat: control infotree modification in Elab.elabSetOption with flag
af08e74
@thorimur
fix: withSetOptionIn: do not modify infotrees or fail on invalid op…
5c5b1ea 
…tions
@thorimur
test: withSetOptionIn preserves infotree structure and does not error
75c78d1
@thorimur
test: tweak
0b00c94
@thorimur
chore: fix tests (how did these get broken?)
1ba6ca7
@thorimur
chore: #guard_msgs to make outcomes more visible
ebf15fc
@thorimur
chore: typos, reformat
9fd7fb7
@thorimur
chore: typos
299edce
@thorimur
docs: PR number, newlines
e360515
@thorimur
chore: move withSetOptionIn to Linter.Basic
957489d
@thorimur
chore: preserve namespacing
8ab5bc0
@thorimur
chore: remove context checks from listVariablesLinter and `indexLin…
598f789 
…ter`
@thorimur
test: listVariables, indexVariables linters
85517e7
@thorimur
chore: shuffle imports?
7ac8578
@thorimur
Revert "chore: shuffle imports?"
8945634 
This reverts commit 0250f5b.
@thorimur
Revert "chore: preserve namespacing"
dad446a 
This reverts commit 8024f79.
@thorimur
Revert "chore: move withSetOptionIn to Linter.Basic"
93f7594 
This reverts commit c30303e.
@thorimur
test: add extra test
60124fd
@thorimur
chore: change test section name
3f5b103
@thorimur
chore: update missing docs linter to reflect withSetOptionIn, leave…
68b5fb3 
… comment
@thorimur
chore: tweak docs
c6e8e15
@thorimur
chore: update tests to use a linter that actually uses withSetOptionIn
0a32b7e
@thorimur
chore: tweak docs
c1209a5
@thorimur
style: condense
1331bda
@thorimur
chore: rename Lean.Linter.Basic -> Lean.Linter.Init
ae7d3f8
@thorimur
chore: restore Lean.Linter.Basic with new content/imports
c54348d
@thorimur
chore: style in MissingDocs.lean
6f08ec9
@thorimur
chore: remove withSetOptionIn from Lean.Elab.Command
32e9c06
@thorimur
chore: open
370ac7a
@thorimur
chore: move tests from elab_fail/ to elab/
5a8fb96
@wkrozowski wkrozowski added the changelog-no Do not include this PR in the release changelog label May 8, 2026
@github-actions github-actions Bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label May 8, 2026
@mathlib-lean-pr-testing
Copy link
Copy Markdown

mathlib-lean-pr-testing Bot commented May 8, 2026 •
edited
Loading

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 355dca6f57c6fec817d67765c566dc6ba6ac84bd --onto 5d5642107d0433519265f155ddbfbfb98007a80b. You can force Mathlib CI using the force-mathlib-ci label. (2026-05-08 10:18:48)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 48ad8401cd5624c944890893a38057ae4920e8ef --onto a71f158f7bd96ff9ea846f7ff4cc658de3c8b0f9. You can force Mathlib CI using the force-mathlib-ci label. (2026-05-11 14:26:13)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 48ad8401cd5624c944890893a38057ae4920e8ef --onto ed0d50fcf0efa8c9a32e1ccb3603ce43edce6926. You can force Mathlib CI using the force-mathlib-ci label. (2026-05-13 11:39:47)
  • 💥 Mathlib branch lean-pr-testing-13688 build failed against this PR. (2026-05-13 12:43:08) View Log
  • ✅ Mathlib branch lean-pr-testing-13688 has successfully built against this PR. (2026-05-14 11:51:23) View Log

@leanprover-bot
Copy link
Copy Markdown
Collaborator

leanprover-bot commented May 8, 2026 •
edited
Loading

Reference manual CI status:

  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase 355dca6f57c6fec817d67765c566dc6ba6ac84bd --onto 5d5642107d0433519265f155ddbfbfb98007a80b. You can force reference manual CI using the force-manual-ci label. (2026-05-08 10:18:50)
  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase 48ad8401cd5624c944890893a38057ae4920e8ef --onto a71f158f7bd96ff9ea846f7ff4cc658de3c8b0f9. You can force reference manual CI using the force-manual-ci label. (2026-05-11 14:26:15)
  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase 48ad8401cd5624c944890893a38057ae4920e8ef --onto ed0d50fcf0efa8c9a32e1ccb3603ce43edce6926. You can force reference manual CI using the force-manual-ci label. (2026-05-13 11:39:49)
  • ✅ Reference manual branch lean-pr-testing-13688 has successfully built against this PR. (2026-05-13 12:45:24) View Log
  • 🟡 Reference manual branch lean-pr-testing-13688 build against this PR didn't complete normally. (2026-05-13 12:46:15) View Log
  • ✅ Reference manual branch lean-pr-testing-13688 has successfully built against this PR. (2026-05-14 11:00:30) View Log
  • 🟡 Reference manual branch lean-pr-testing-13688 build against this PR didn't complete normally. (2026-05-14 11:01:25) View Log

@wkrozowski wkrozowski marked this pull request as ready for review May 11, 2026 11:35
@wkrozowski
Copy link
Copy Markdown
Contributor Author

wkrozowski commented May 11, 2026

!bench

@leanprover-radar
Copy link
Copy Markdown

leanprover-radar commented May 11, 2026 •
edited
Loading

Benchmark results for 18ac8ff against 48ad840 are in. No significant results found. @wkrozowski

  • 🟥 build//instructions: +4.4G (+0.04%)

Small changes (1🟥)

  • 🟥 build/module/Lean.Expr//instructions: +151.4M (+1.19%) (reduced significance based on *//lines)

@wkrozowski wkrozowski added the lake-ci Run all Lake tests label May 13, 2026
@github-actions github-actions Bot added the mathlib4-nightly-available A branch for this PR exists at leanprover-community/mathlib4-nightly-testing:lean-pr-testing-NNNN label May 13, 2026
@mathlib-lean-pr-testing mathlib-lean-pr-testing Bot added the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label May 13, 2026
@leanprover-bot leanprover-bot added the builds-manual CI has verified that the Lean Language Reference builds against this PR label May 13, 2026
mathlib-nightly-testing Bot pushed a commit to leanprover-community/batteries that referenced this pull request May 14, 2026
Update lean-toolchain for leanprover/lean4#13688
97f1e0c
mathlib-nightly-testing Bot pushed a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request May 14, 2026
Update lean-toolchain for leanprover/lean4#13688
49fe620
leanprover-bot added a commit to leanprover/reference-manual that referenced this pull request May 14, 2026
@leanprover-bot
Update lean-toolchain for leanprover/lean4#13688
266705c
@mathlib-lean-pr-testing mathlib-lean-pr-testing Bot added builds-mathlib CI has verified that Mathlib builds against this PR and removed breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan labels May 14, 2026
@wkrozowski wkrozowski added this pull request to the merge queue May 14, 2026
Merged via the queue into leanprover:master with commit f459c14 May 14, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@digama0 digama0 Awaiting requested review from digama0

@leodemoura leodemoura Awaiting requested review from leodemoura

@kim-em kim-em Awaiting requested review from kim-em

Assignees

No one assigned

Labels

builds-manual CI has verified that the Lean Language Reference builds against this PR builds-mathlib CI has verified that Mathlib builds against this PR changelog-no Do not include this PR in the release changelog lake-ci Run all Lake tests mathlib4-nightly-available A branch for this PR exists at leanprover-community/mathlib4-nightly-testing:lean-pr-testing-NNNN toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wkrozowski @leanprover-bot @leanprover-radar @thorimur