Skip to content

feat: add WallTime and simplify Timestamp API#13675

Merged
algebraic-dev merged 6 commits into
masterfrom
sofia/add-walltime
May 11, 2026
Merged

feat: add WallTime and simplify Timestamp API#13675
algebraic-dev merged 6 commits into
masterfrom
sofia/add-walltime

Conversation

@algebraic-dev
Copy link
Copy Markdown
Member

This PR adds a WallTime type representing a point in time as nanoseconds since 1970-01-01T00:00:00 local time. It also removes the sinceUNIXEpoch and AssumingUTC suffixes because Timestamp implies UTC, and WallTime implies it is based on the WallTime epoch (defined in the comment as 1970-01-01T00:00:00).

@algebraic-dev algebraic-dev self-assigned this May 7, 2026
@algebraic-dev algebraic-dev requested a review from TwoFX as a code owner May 7, 2026 03:03
@github-actions github-actions Bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label May 7, 2026
@mathlib-lean-pr-testing
Copy link
Copy Markdown

mathlib-lean-pr-testing Bot commented May 7, 2026

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase aa6fa1cf1a7c7a7161ceeda64c934176abc3595b --onto ea6e76707835317858b7dd36c95322679c50aaac. You can force Mathlib CI using the force-mathlib-ci label. (2026-05-07 04:09:09)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase a416b90d22990f84607168ac6c520b52c843a25d --onto a71f158f7bd96ff9ea846f7ff4cc658de3c8b0f9. You can force Mathlib CI using the force-mathlib-ci label. (2026-05-11 13:31:42)

@leanprover-bot
Copy link
Copy Markdown
Collaborator

leanprover-bot commented May 7, 2026

Reference manual CI status:

  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase aa6fa1cf1a7c7a7161ceeda64c934176abc3595b --onto 3fc99eef102549c743c6c63547983319bfae6f01. You can force reference manual CI using the force-manual-ci label. (2026-05-07 04:09:11)
  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase aa6fa1cf1a7c7a7161ceeda64c934176abc3595b --onto 5d5642107d0433519265f155ddbfbfb98007a80b. You can force reference manual CI using the force-manual-ci label. (2026-05-07 18:20:37)
  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase a416b90d22990f84607168ac6c520b52c843a25d --onto a71f158f7bd96ff9ea846f7ff4cc658de3c8b0f9. You can force reference manual CI using the force-manual-ci label. (2026-05-11 13:31:44)

Comment thread src/Std/Time/DateTime/Timestamp.lean Outdated
Comment thread src/Std/Time/DateTime/WallTime.lean Outdated
Comment thread src/Std/Time/DateTime/WallTime.lean
Comment thread src/Std/Time/Zoned/DateTime.lean Outdated
Comment thread src/Std/Time/Zoned/DateTime.lean Outdated
Comment thread src/Std/Time/Zoned/DateTime.lean
Comment thread src/Std/Time/Zoned/ZonedDateTime.lean Outdated
Comment thread src/Std/Time/Zoned/ZoneRules.lean Outdated
Copy link
Copy Markdown
Member

@TwoFX TwoFX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Comment thread src/Std/Time/Date/PlainDate.lean Outdated
Comment thread src/Std/Time/Date/PlainDate.lean Outdated
Co-authored-by: Julia Markus Himmel <2065352+TwoFX@users.noreply.github.com>
@algebraic-dev algebraic-dev added this pull request to the merge queue May 11, 2026
Merged via the queue into master with commit f67ea44 May 11, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-library Library toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants