feat: some lemmas about Euclidean relations#557
Open
chenson2018 wants to merge 2 commits intomainfrom
Open
Conversation
ctchou
approved these changes
May 10, 2026
Collaborator
ctchou
left a comment
ctchou
left a comment
There was a problem hiding this comment.
LGTM, except for the comment below.
|
|
||
| end RightEuclidean | ||
|
|
||
| namespace LeftEuclidean |
Collaborator
There was a problem hiding this comment.
I wonder if the theorems in this section can be derived from those in the section RightEucliean using the duality between left and right Euclidean relations (namely, via leftEuclidean_swap). As more theorems are added, going through the duality will probably save some work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some lemmas on Euclidean relations, including defining
LeftEuclideanto accompany the existingRightEuclidean. I erred on the side of leaving most of these as theorems, as these are a bit problematic if all made instances.I will note again that these existed in FFL, but this adds a bit more than is proven there.