You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With this, if two or more LCFIplus processors are used in the same event, LCIOStorer::SetEvent would be called more than once: clearing the objects and relations, and doing the conversions.
Instead of using a static object, or setting the event multiple times, one could also store the LCIOStorer object per event, and retrieve it in the following LCFIplus processors.
I don't know how multiple LCIOStorers work while the Event (and EventStore) is still a singleton.
Would you explain how you consider to run multi-threading? Processing a same event in parallel or treating completely different events at the same time?
If it's the first case maybe it's better to implement some signaling function to assure one event is loaded and all processors are finished before going to the next event (need some work). On the latter case everything needs to be duplicated, which may be possible but need careful consideration. At least Event class (and EventStore) should be kept one per thread and we need to ensure this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
LCIOStorerto be able to run various LCFIplus processors concurrently or in parallel.ENDRELEASENOTES