Skip to content

Fix: Styling Issue With Text#1374

Merged
Rajesh-Nagarajan-11 merged 6 commits intolayer5io:masterfrom
banana-three-join:bug/banana-three-join/feedback_modal_button
Mar 25, 2026
Merged

Fix: Styling Issue With Text#1374
Rajesh-Nagarajan-11 merged 6 commits intolayer5io:masterfrom
banana-three-join:bug/banana-three-join/feedback_modal_button

Conversation

@banana-three-join
Copy link
Contributor

@banana-three-join banana-three-join commented Mar 22, 2026

Notes for Reviewers

This PR fixes #1373

Here's a video showcasing the buttons working as intended:
https://www.loom.com/share/013333486eb74e518160d238911efac7

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Lenox Wiltshire <lenoxwiltshire@gmail.com>
Copy link
Member

@Rajesh-Nagarajan-11 Rajesh-Nagarajan-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can set the icon color to theme.palette.icon.default when it is in the clicked state.

@banana-three-join banana-three-join force-pushed the bug/banana-three-join/feedback_modal_button branch from 2748798 to e092bf3 Compare March 25, 2026 06:10
@Rajesh-Nagarajan-11 Rajesh-Nagarajan-11 merged commit ecb65c2 into layer5io:master Mar 25, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] The Text in Feedback Buttons Becomes Invisible When Clicked

2 participants