Provide request id in log output#22
Open
medikoo wants to merge 1 commit intolaurisvan:masterfrom
Open
Conversation
Owner
|
This one is interesting - indeed the requests might get entangled. I wonder if there were a way to inject case specific needs into the logs etc. While there's nothing wrong in this one, I wonder if this will open Pandora's box for appending just about everything case-by-case to the requests... Let me elaborate a bit on this one and get back to you shortly. |
Contributor
Author
|
In MaaS projects we had cases where it's difficult to clearly deduct what comes from which requests, and it made debugging additionally cumbersome. |
Contributor
Author
|
Here is an example of logs where it's no upfront clear what responses match what requests: Missing that information unfortunately increases debugging time on our side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are situations where many requests are run in parallel, then log output may become unclear on which logs refer to which request (especially when we deal with errors).
This patch ensures that logs of specific request can easily be recognized.