chore: add explicit permissions to release-please workflow#58
Merged
kinyoklion merged 3 commits intomainfrom Mar 25, 2026
Merged
chore: add explicit permissions to release-please workflow#58kinyoklion merged 3 commits intomainfrom
kinyoklion merged 3 commits intomainfrom
Conversation
Co-Authored-By: rlamb@launchdarkly.com <kingdewman@gmail.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
joker23
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
No test changes needed — this is a CI workflow configuration change only.
Related issues
N/A — identified during an audit of all non-archived
launchdarkly-sdk-tagged repositories for missing release-please workflow permissions.Describe the solution you've provided
Adds explicit
contents: writeandpull-requests: writepermissions to therelease-pleasejob. These are required for the release-please action to:pull-requests: write)contents: write)Without explicit permissions, the job relies on the repository/org default
GITHUB_TOKENpermissions, which may be insufficient if defaults are tightened to read-only.Describe alternatives you've considered
Setting permissions at the workflow level (top-level
permissions:key) was considered, but job-level scoping follows the principle of least privilege and avoids granting unnecessary access to the downstreampublish-packagejob (which already has its own explicit permissions block).Additional context
This is part of a batch update across all
launchdarkly-sdk-tagged repositories whose release-please workflows were missing explicit permissions on their default branch.Human review checklist
permissionsblock restricts the token to only the listed permissions (plusmetadata: read), revoking any previously inherited defaults. Confirm therelease-pleasejob does not need additional permissions (e.g.,id-token: write).publish-packagejob is unaffected (it has its ownpermissionsblock).Link to Devin session: https://app.devin.ai/sessions/a83b6e4f4fa14b96b859cfb50755a2c1
Requested by: @kinyoklion
Note
Low Risk
Low risk CI change that only scopes
GITHUB_TOKENpermissions for therelease-pleasejob; main risk is inadvertently missing a required permission and breaking automated release PR/tag creation.Overview
Adds an explicit
permissionsblock to therelease-pleaseGitHub Actions job, grantingcontents: writeandpull-requests: writeso the release-please action can create/update release PRs and publish tags/releases even when default token permissions are restricted.Written by Cursor Bugbot for commit d6558fc. This will update automatically on new commits. Configure here.