Wrap scal#331
Draft
amklinv-nnl wants to merge 2 commits into
Draft
Conversation
This is for discussion of issue kokkos#328.
mhoemmen
reviewed
May 28, 2026
Comment on lines
+77
to
+78
| auto incx = x.stride(0); | ||
| if (x.is_strided() && n <= std::numeric_limits<CBLAS_INDEX>::max()) { |
Contributor
There was a problem hiding this comment.
-
Per [mdspan.layout.reqmnts] 19, we can't call
x.stride(0)until we know thatx.is_strided()istrue. -
incxmight be larger thann.
Suggested change
| auto incx = x.stride(0); | |
| if (x.is_strided() && n <= std::numeric_limits<CBLAS_INDEX>::max()) { | |
| if (x.is_strided() && n <= std::numeric_limits<int>::max()) { | |
| auto incx = x.stride(0); | |
| if (incx > std::numeric_limits<int>::max()) { | |
| return false; | |
| } |
Contributor
There was a problem hiding this comment.
It's also acceptable to turn this into a compile-time check. We don't have to worry too much about weird layouts for which is_strided() is true sometimes but is_always_strided() is false.
if constexpr (! x.is_always_strided()) {
return false;
}
Contributor
There was a problem hiding this comment.
Also, strided layout mappings can have stride zero. layout_stride cannot, unless its corresponding extent is also zero. If incx is zero, then we should also return false.
mhoemmen
requested changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE.
For discussion in #328