Skip to content

feat: release pr context.#54

Merged
knightedcodemonkey merged 3 commits intomainfrom
bananas
Mar 31, 2026
Merged

feat: release pr context.#54
knightedcodemonkey merged 3 commits intomainfrom
bananas

Conversation

@knightedcodemonkey
Copy link
Copy Markdown
Owner

Copilot AI review requested due to automatic review settings March 31, 2026 20:17
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR makes the PR/BYOT (Bring Your Own Token) GitHub controls available by default (no AI feature flag required) while keeping AI chat functionality opt-in behind ?feature-ai=true, aligning with the “release PR creation” portion of Issue #18.

Changes:

  • Removed featureEnabled gating/early-return stubs from the PR drawer and BYOT controls modules so PR/BYOT can run by default.
  • Updated app UI sync so the PR toggle can appear when a token is present even if AI chat is feature-flagged off.
  • Updated docs and Playwright coverage to reflect “PR/BYOT always available, chat behind feature flag”.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/modules/github-pr-drawer.js Removes feature-flag short-circuit so PR drawer controller always initializes.
src/modules/github-byot-controls.js Removes feature-flag short-circuit so BYOT controls logic always initializes.
src/app.js Updates visibility logic to keep chat behind the flag but allow PR/BYOT by default.
README.md Documents that AI chat remains behind ?feature-ai=true.
docs/byot.md Reframes BYOT as default behavior; AI chat becomes the feature-flagged portion.
docs/next-steps.md Updates roadmap language to reflect PR/BYOT default + AI chat behind flag.
playwright/github-byot-ai.spec.ts Updates tests for new visibility expectations when the feature flag is off.
Comments suppressed due to low confidence (1)

src/app.js:231

  • #github-ai-controls starts with the hidden attribute in index.html, but setCompactAiControlsOpen() only calls githubAiControls.removeAttribute('hidden') in the non-compact viewport branch. If the app loads in a compact viewport (<=900px), toggling the GitHub controls sets data-compact-open but the element remains hidden, so the PR/BYOT controls can never be opened. Consider removing the hidden attribute unconditionally before the viewport split (and let CSS handle compact display:none), or explicitly remove it in the compact branch when opening.
  aiControlsToggle.removeAttribute('hidden')

  if (!isCompactViewport()) {
    compactAiControlsOpen = false
    setGitHubTokenInfoOpen(false)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@knightedcodemonkey knightedcodemonkey merged commit 6ec6037 into main Mar 31, 2026
5 checks passed
@knightedcodemonkey knightedcodemonkey deleted the bananas branch March 31, 2026 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants