[WIP] Add ability to render ISBN data with verification#370
Merged
Conversation
Closed
Agent-Logs-Url: https://github.com/kit-data-manager/pid-component/sessions/ed78e66c-7855-4266-881d-6857e2baeaa9 Co-authored-by: maximiliani <43142805+maximiliani@users.noreply.github.com>
Copilot stopped work on behalf of
maximiliani due to an error
May 13, 2026 19:31
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
🎨 Chromatic Visual Tests🔍 Visual changes detected ReviewChromatic provides automated visual testing and review for component changes. |
Test ResultsCoverage Summary
Coverage & Quality Reports📊 Codecov Report For more details, check the workflow run |
Agent-Logs-Url: https://github.com/kit-data-manager/pid-component/sessions/5ebcc8d8-fc75-4d23-8ed1-bf6c740407ca Co-authored-by: maximiliani <43142805+maximiliani@users.noreply.github.com>
Member
|
@copilot rebase from main. Remove and gitignore test-results.junit.xml. |
Co-authored-by: maximiliani <43142805+maximiliani@users.noreply.github.com>
Signed-off-by: Maximilian Inckmann <maximilian.inckmann@kit.edu> Co-authored-by: maximiliani <43142805+maximiliani@users.noreply.github.com>
Signed-off-by: Maximilian Inckmann <maximilian.inckmann@kit.edu> Co-authored-by: maximiliani <43142805+maximiliani@users.noreply.github.com>
Co-authored-by: maximiliani <43142805+maximiliani@users.noreply.github.com>
Contributor
Author
Done in I rebased the branch with the latest main history, and Screenshot (ISBN renderer after rebase): Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Signed-off-by: Maximilian Inckmann <maximilian.inckmann@kit.edu>
Signed-off-by: Maximilian Inckmann <maximilian.inckmann@kit.edu>
Signed-off-by: Maximilian Inckmann <maximilian.inckmann@kit.edu>
Signed-off-by: Maximilian Inckmann <maximilian.inckmann@kit.edu>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an ISBN renderer module (ISBN-10/13 detection, checksum validation, OpenLibrary metadata) to the stencil-library, wires it into the renderer registry and public exports, ships example values/texts and a Storybook story, and adds a unit test suite. The PR also performs a large README cleanup (moving development docs to a new DEVELOPMENT.md), bumps several dev dependencies, and touches a number of auto-generated framework-wrapper files plus a few unrelated CI/Storybook tweaks.
Changes:
- Introduce
ISBNTyperenderer with checksum validation and OpenLibrary lookup, register it inutils/renderers, export it fromindex.ts. - Add
examples/isbnfixtures, a Storybook story, and a Vitest unit suite for the new renderer. - Refactor
README.md(split outDEVELOPMENT.md), bump dev deps, and adjust auto-detect/TextReplacer + Storybook intro stories.
Reviewed changes
Copilot reviewed 37 out of 41 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/stencil-library/src/rendererModules/ISBNType/ISBNType.tsx | New ISBN renderer implementation. |
| packages/stencil-library/src/rendererModules/ISBNType/ISBN.stories.ts | Storybook story for ISBN renderer. |
| packages/stencil-library/src/rendererModules/ISBNType/tests/ISBNType.unit.ts | Unit tests for the ISBN renderer. |
| packages/stencil-library/src/utils/utils.ts | Registers ISBNType; adjusts CrossRefDOIType priority. |
| packages/stencil-library/src/index.ts | Exports ISBNType. |
| packages/stencil-library/src/auto-detect/TextReplacer.ts | Stops forcing matched renderer key on generated <pid-component>. |
| examples/isbn/{values,texts,index}.ts, examples/index.ts | New ISBN example fixtures. |
| README.md, DEVELOPMENT.md, .storybook/intro.mdx, .storybook/intro.stories.ts, .storybook/preview.ts | Documentation/Storybook reorg and an introduction snippet update (contains a stray "). |
| packages/stencil-library/src/auto-detect/auto-detect.stories.ts | Showcase HTML cleanup. |
| packages/stencil-library/src/components/color-highlight/tests/color-highlight.source.spec.tsx | Removes one color-highlight test. |
| packages/stencil-library/src/components.d.ts, packages/{vue,react,angular}-library/...generated... | Hand-edited auto-generated wrapper files. |
| package.json, package-lock.json, packages/*/package.json | Dev dependency bumps (Playwright, Vitest, Mantine, Angular CLI, tailwind-merge, etc.). |
| .github/workflows/publish.yml | Drops chromium-only Playwright install and --coverage flag. |
| packages/vue-library/.nuxt/manifest/meta/e7659a2b-01f9-4884-b116-efba3d7faaff.json | Deletes a Nuxt build-artifact file. |
Comments suppressed due to low confidence (1)
packages/vue-library/.nuxt/manifest/meta/e7659a2b-01f9-4884-b116-efba3d7faaff.json:1
- This file lives under
.nuxt/, which is a build artifact directory typically regenerated by Nuxt and should not be checked in. Consider addingpackages/vue-library/.nuxt/to.gitignoreand removing the directory from the repository rather than committing/deleting individual generated files in PRs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| 'value', | ||
| 'label', | ||
| 'darkMode', | ||
| 'darkMode' |
Comment on lines
31
to
32
| it('applies inline color style', async () => { | ||
| const { root } = await render(<color-highlight text="test"></color-highlight>); |
Member
|
@copilot resolve the merge conflicts in this pull request |
Co-authored-by: maximiliani <43142805+maximiliani@users.noreply.github.com>
Signed-off-by: Maximilian Inckmann <maximilian.inckmann@kit.edu>
Signed-off-by: Maximilian Inckmann <maximilian.inckmann@kit.edu>
Contributor
Author
Resolved in Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
maximiliani
approved these changes
May 15, 2026
🎨 Chromatic Visual Tests🔍 Visual changes detected ReviewChromatic provides automated visual testing and review for component changes. |
Test ResultsCoverage Summary
Coverage & Quality Reports📊 Codecov Report For more details, check the workflow run |
Signed-off-by: Maximilian Inckmann <maximilian.inckmann@kit.edu>
Signed-off-by: Maximilian Inckmann <maximilian.inckmann@kit.edu>
Enable import injection in Stencil configuration and minor fixes
🎨 Chromatic Visual Tests🔍 Visual changes detected ReviewChromatic provides automated visual testing and review for component changes. |
Test ResultsCoverage Summary
Coverage & Quality Reports📊 Codecov Report For more details, check the workflow run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.