fix: Check embed for "new search" and dedicated landing pages#736
fix: Check embed for "new search" and dedicated landing pages#736darcywong00 wants to merge 1 commit into
Conversation
User Test ResultsTest specification and instructions User tests are not required |
dbfe69c to
801511c
Compare
mcdurdin
left a comment
There was a problem hiding this comment.
LGTM, I am not sure how the /h/ pages slipped through because I did test those...
hmm, current staging site (before I merge this) Starting at redirects and settles on https://keyman-staging.com/keyboards/?q=ipa in an embedded search with the cookie Clicking the top link (landing page to /ipa) goes to https://keyman-staging.com/en/keyboards/h/ipa/?embed=android&version=10.0.0.0
|
|
Ah I think we need to set the path of the cookie! |
|
|
It is important to add the path for the cookie as shown above, but we still need your patch as well. I'll add the cookie as a separate PR |
Follows the
page_rootpattern in #734 for the "New Search" link.For Keyman 14.0-18.0 apps using the embedded view, we don't include the locale for "Near Search"
Also added a section in .htaccess so dedicated landing pages can check the
embedsession cookie.Fortunately, all the landing pages are
index.php.Test-bot: skip