Add VHS timing sync command and optional pipeline integration#19
Merged
Add VHS timing sync command and optional pipeline integration#19
Conversation
… paths Co-authored-by: John Menke <jmjava@gmail.com>
Co-authored-by: John Menke <jmjava@gmail.com>
Co-authored-by: John Menke <jmjava@gmail.com>
Co-authored-by: John Menke <jmjava@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR contains the VHS timing sync bundle:
docgen sync-vhscommand to rewrite tapeSleepdurations fromtiming.jsontimestampsIt also includes a follow-up merge-resolution commit after syncing with latest
origin/main.What changed
New command:
docgen sync-vhsAdded
src/docgen/tape_sync.pyand new CLI command:Behavior:
animations/timing.json.tapefiles forType -> Enter -> Sleepblocks after the firstShowSleepusing:len(typed_text) * typing_ms_per_charmax_typing_secmin_sleep_sec--dry-runis setOptional pipeline integration after timestamps
Pipeline now optionally runs VHS tape sync immediately after
timestamps:pipeline.sync_vhs_after_timestampsvhs.sync_from_timingdocgen generate-all --skip-tape-syncConfig additions
Added in
Config:pipeline.sync_vhs_after_timestamps(defaultfalse)vhs.sync_from_timing(defaultfalse)vhs.typing_ms_per_char(default45)vhs.max_typing_sec(default2.5)vhs.min_sleep_sec(default0.1)Scaffolding/docs updates
docgen initnow writes sync options into generated config.docgen sync-vhscommandgenerate-all --skip-tape-syncdocs/demos/docgen.yamlupdated with example sync settings.Merge conflict resolution with latest main
After fetching and merging
origin/main, conflicts were found in:README.mddocs/demos/docgen.yamlsrc/docgen/config.pysrc/docgen/init.pytests/test_config.pyClassification:
Resolution approach:
Configinitwhere appropriateTests
Added:
tests/test_tape_sync.pyUpdated:
tests/test_config.pyfor new sync config accessorsVerification
python3 -m pytest tests -q --ignore=tests/e2e-> 84 passedpython3 -m ruff check src tests-> All checks passedIssue linkage
Closes #11
Closes #14