Conversation
… paths Co-authored-by: John Menke <jmjava@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements a focused pipeline-correctness pass covering:
What changed
1) Manim quality mapping + path resolution (#6)
ManimRunner:480p15,720p30,1080p60,2160p601080p30,1440p30, etc. via explicit--resolution+--frame_ratemanim.quality(with fallbacks), including both:animations/media/videos/scenes/<quality>/...animations/media/videos/<quality>/...2) Binary resolution for manim/vhs (#7)
src/docgen/binaries.pywith shared binary resolution helper.manimresolution now supports:manim.manim_pathfrom configsys.executable)vhsresolution now supports:vhs.vhs_pathfrom config~/go/bin/vhs,/usr/local/bin/vhs,/snap/bin/vhs)3) Stale VHS warning in compose (#12)
terminal/*.tapeis newer thanterminal/rendered/*.mp4compose.warn_stale_vhs(defaulttrue).4) Configurable ffmpeg timeout (#13)
compose.ffmpeg_timeout_sec(default300).docgen compose --ffmpeg-timeout <seconds>.ComposeErrorfor hard failures (missing ffmpeg, non-zero exit, timeout without output)5) Config/docs/init updates
Config:manim_path,vhs_path,ffmpeg_timeout_sec,warn_stale_vhsdocgen initgenerated config to includemanim_path,vhs_path, and compose timeout/stale warning options.vhs -> composeguidance after tape editsTests
tests/test_manim_runner.pytests/test_compose.pytests/test_config.py.python3 -m pytest tests -q --ignore=tests/e2e-> 81 passedpython3 -m ruff check src tests-> All checks passedIssue linkage
Closes #6
Closes #7
Closes #12
Closes #13