Skip to content

Enhance search log filter with term support#3236

Open
limad wants to merge 1 commit intojeedom:alphafrom
limad:patch-6
Open

Enhance search log filter with term support#3236
limad wants to merge 1 commit intojeedom:alphafrom
limad:patch-6

Conversation

@limad
Copy link
Copy Markdown
Contributor

@limad limad commented Apr 1, 2026

Titre : Refactor search functionality to support multiple terms and :not filter.

Description

The log filter input (in_searchLogFilter) previously supported only a single search term at a time, requiring users to retype their query to switch between logs.

This refactor allows multiple comma-separated terms to be entered simultaneously (e.g. ai_assistant,jee_mcp), so several logs can be highlighted at once. The existing :not() syntax is preserved and now works per-term, meaning it can be mixed with positive terms in the same query.

No changes to the PHP side or the rest of the JS page were required.

Suggested changelog entry

Log filter now supports multiple comma-separated terms and per-term :not() exclusion.

Related issues/external references

Fixes #

Types of changes

  • Bug fix
  • New feature (non-breaking change which adds functionality)
  • Breaking change
  • Documentation improvement

PR checklist

  • I have checked there is no other PR open for the same change.
  • I have read the contribution guidelines.
  • I grant the project the right to include and distribute the code under the GNU.
  • I have added tests to cover my changes.
  • I have verified that the code complies with the projects coding standards.
  • [Required for new sniffs] I have added MD documentation for the sniff.

Refactor search functionality to support multiple terms and :not filter.
@Mips2648 Mips2648 changed the base branch from alpha to develop April 2, 2026 06:22
@Mips2648 Mips2648 changed the base branch from develop to alpha April 2, 2026 06:22
Copy link
Copy Markdown
Collaborator

@Mips2648 Mips2648 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,
Thanks for this PR!
Unfortunately it will be impossible to accept because there is an ongoing workflow migration (to use the standard gitflow) on the repo and PR shouldn't be done on alpha anymore but on develop. Documentation still needs to be adapted.
We cannot rebase the PR automatically because there are some unwanted changes in alpha (due to jenkins)

Could you please resubmit your PR on develop please?

Comment thread desktop/js/log.js
}
search = jeedomUtils.normTextLower(search)

// Découpe sur la virgule → liste de termes (avec support :not par terme)
Copy link
Copy Markdown
Collaborator

@Mips2648 Mips2648 Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • no comment in french
  • I don't think this is relevant to let a comment here as the code speak by itself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants