Fix TextScaledButtonWidget rendering on >=1.21.11#322
Open
soradotwav wants to merge 1 commit intoisXander:mainfrom
Open
Fix TextScaledButtonWidget rendering on >=1.21.11#322soradotwav wants to merge 1 commit intoisXander:mainfrom
soradotwav wants to merge 1 commit intoisXander:mainfrom
Conversation
Owner
|
The reason I did not do this is because I wanted to continue to use the vanilla ActiveTextCollector rather than falling back to GuiGraphicsExtractor. Thank you for bringing this back to attention I will try and research how to do it properly. If not, I'll merge this, given you fix the merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I replaced the placeholder renderDefaultLabel override with a proper renderContents implementation. It now actually calculates the correct translation to keep the text centered while scaled, so we don't have to settle for tiny buttons anymore.
Also cleaned up some unused imports and updated the matrix math to work with the new GuiGraphics setup.